-
Notifications
You must be signed in to change notification settings - Fork 412
Add nativeSpawn option to RunCLIArgs for host process spawning #3481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chubes4
wants to merge
7
commits into
WordPress:trunk
Choose a base branch
from
chubes4:fix/native-spawn-handler
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d48c0e4
Add nativeSpawn option to RunCLIArgs for host process spawning
chubes4 eccaf89
Add standalone spawn handler test script
chubes4 d312240
Remove standalone test script with hardcoded paths
chubes4 e13a837
Address review feedback: security warning, ESM compat, test name
chubes4 c076c6b
Skip proc_open tests on Windows (no /bin/echo)
chubes4 1ec3c29
Fix proc_open with native spawn: VFS cwd and ESM import
chubes4 1498af1
fix: remove unused imports in php-proc-open-daemon.spec.ts
chubes4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
193 changes: 193 additions & 0 deletions
193
packages/php-wasm/node/src/test/php-proc-open-daemon.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,193 @@ | ||
| /** | ||
| * Tests proc_open behavior across different execution contexts. | ||
| * | ||
| * proc_open works with php.run() but fails through the daemon/CLI path. | ||
| * These tests isolate where the spawn handler gets lost: | ||
| * | ||
| * 1. php.run() — direct PHP execution (known working) | ||
| * 2. php.cli() — WP-CLI-style execution on same instance | ||
| * 3. Runtime rotation — does enableRuntimeRotation preserve the handler? | ||
| * 4. Worker thread — does the worker thread path preserve the handler? | ||
| */ | ||
| import { spawn } from 'child_process'; | ||
| import { PHP, ProcessIdAllocator } from '@php-wasm/universal'; | ||
| import { loadNodeRuntime } from '../lib'; | ||
|
|
||
| const isWindows = process.platform === 'win32'; | ||
| const describeUnix = isWindows ? describe.skip : describe; | ||
|
|
||
| const processIdAllocator = new ProcessIdAllocator(); | ||
|
|
||
| const PROC_OPEN_TEST_CODE = `<?php | ||
| $desc = [0 => ['pipe', 'r'], 1 => ['pipe', 'w'], 2 => ['pipe', 'w']]; | ||
| $proc = proc_open('/bin/echo proc_open_works', $desc, $pipes); | ||
| if (is_resource($proc)) { | ||
| $stdout = stream_get_contents($pipes[1]); | ||
| fclose($pipes[0]); | ||
| fclose($pipes[1]); | ||
| fclose($pipes[2]); | ||
| proc_close($proc); | ||
| echo trim($stdout); | ||
| } else { | ||
| echo 'PROC_OPEN_FAILED'; | ||
| } | ||
| `; | ||
|
|
||
| describeUnix('proc_open spawn handler propagation', () => { | ||
| let php: PHP; | ||
|
|
||
| afterEach(() => { | ||
| try { | ||
| php.exit(); | ||
| } catch { | ||
| // ignore | ||
| } | ||
| }); | ||
|
|
||
| it('works with php.run() — baseline', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
|
|
||
| const result = await php.run({ code: PROC_OPEN_TEST_CODE }); | ||
| expect(result.text).toBe('proc_open_works'); | ||
| }); | ||
|
|
||
| it('works with php.cli() — CLI execution path', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
| await php.setSapiName('cli'); | ||
|
|
||
| php.writeFile('/tmp/test-proc-open.php', PROC_OPEN_TEST_CODE); | ||
|
|
||
| const result = await php.cli(['php', '/tmp/test-proc-open.php']); | ||
| const stdout = await result.stdoutText; | ||
| expect(stdout.trim()).toBe('proc_open_works'); | ||
| }); | ||
|
|
||
| it('survives runtime rotation', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
|
|
||
| // Enable runtime rotation (this is what bootRequestHandler does) | ||
| php.enableRuntimeRotation({ | ||
| maxRequests: 400, | ||
| recreateRuntime: () => | ||
| loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }), | ||
| }); | ||
|
|
||
| const result = await php.run({ code: PROC_OPEN_TEST_CODE }); | ||
| expect(result.text).toBe('proc_open_works'); | ||
| }); | ||
|
|
||
| it('survives runtime rotation + cli()', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
| await php.setSapiName('cli'); | ||
|
|
||
| php.enableRuntimeRotation({ | ||
| maxRequests: 400, | ||
| recreateRuntime: () => | ||
| loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }), | ||
| }); | ||
|
|
||
| php.writeFile('/tmp/test-proc-open.php', PROC_OPEN_TEST_CODE); | ||
|
|
||
| const result = await php.cli(['php', '/tmp/test-proc-open.php']); | ||
| const stdout = await result.stdoutText; | ||
| expect(stdout.trim()).toBe('proc_open_works'); | ||
| }); | ||
|
|
||
| it('works after runtime has been rotated', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
|
|
||
| php.enableRuntimeRotation({ | ||
| maxRequests: 1, // Force rotation after every request | ||
| recreateRuntime: () => | ||
| loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }), | ||
| }); | ||
|
|
||
| // First request — uses original runtime | ||
| const result1 = await php.run({ | ||
| code: '<?php echo "first";', | ||
| }); | ||
| expect(result1.text).toBe('first'); | ||
|
|
||
| // Second request — runtime has been rotated | ||
| const result2 = await php.run({ code: PROC_OPEN_TEST_CODE }); | ||
| expect(result2.text).toBe('proc_open_works'); | ||
| }); | ||
|
|
||
| it('works after runtime rotation via cli()', async () => { | ||
| php = new PHP( | ||
| await loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }) | ||
| ); | ||
| await php.setSpawnHandler(spawn as any); | ||
| await php.setSapiName('cli'); | ||
|
|
||
| php.enableRuntimeRotation({ | ||
| maxRequests: 1, // Force rotation after every request | ||
| recreateRuntime: () => | ||
| loadNodeRuntime('8.3', { | ||
| emscriptenOptions: { | ||
| processId: processIdAllocator.claim(), | ||
| }, | ||
| }), | ||
| }); | ||
|
|
||
| // First request triggers rotation | ||
| await php.run({ code: '<?php echo "warmup";' }); | ||
|
|
||
| // Second request on rotated runtime, via cli() | ||
| php.writeFile('/tmp/test-proc-open.php', PROC_OPEN_TEST_CODE); | ||
| const result = await php.cli(['php', '/tmp/test-proc-open.php']); | ||
| const stdout = await result.stdoutText; | ||
| expect(stdout.trim()).toBe('proc_open_works'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { spawn } from 'child_process'; | ||
| import { | ||
| SupportedPHPVersions, | ||
| setPhpIniEntries, | ||
| PHP, | ||
| type SpawnHandler, | ||
| } from '@php-wasm/universal'; | ||
| import { loadNodeRuntime } from '../lib'; | ||
|
|
||
| const phpVersions = | ||
| 'PHP' in process.env ? [process.env['PHP']!] : SupportedPHPVersions; | ||
|
|
||
| // These tests use /bin/echo and /bin/sh which are not available on Windows. | ||
| const isWindows = process.platform === 'win32'; | ||
| const describeUnix = isWindows ? describe.skip : describe; | ||
|
|
||
| describeUnix.each(phpVersions)('PHP %s – proc_open', (phpVersion) => { | ||
| let php: PHP; | ||
|
|
||
| beforeEach(async () => { | ||
| php = new PHP(await loadNodeRuntime(phpVersion as any)); | ||
| await setPhpIniEntries(php, { allow_url_fopen: 1 }); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| php.exit(); | ||
| }); | ||
|
|
||
| it('proc_open works with native spawn handler', async () => { | ||
| await php.setSpawnHandler(spawn as unknown as SpawnHandler); | ||
|
|
||
| const result = await php.run({ | ||
| code: `<?php | ||
| $desc = [ | ||
| 0 => ['pipe', 'r'], | ||
| 1 => ['pipe', 'w'], | ||
| 2 => ['pipe', 'w'], | ||
| ]; | ||
| $proc = proc_open('/bin/echo hello_from_proc_open', $desc, $pipes); | ||
| if (is_resource($proc)) { | ||
| $stdout = stream_get_contents($pipes[1]); | ||
| fclose($pipes[0]); | ||
| fclose($pipes[1]); | ||
| fclose($pipes[2]); | ||
| $code = proc_close($proc); | ||
| echo trim($stdout); | ||
| } else { | ||
| echo 'PROC_OPEN_FAILED'; | ||
| } | ||
| `, | ||
| }); | ||
|
|
||
| expect(result.text).toBe('hello_from_proc_open'); | ||
| }); | ||
|
|
||
| it('shell_exec works with native spawn handler', async () => { | ||
| await php.setSpawnHandler(spawn as unknown as SpawnHandler); | ||
|
|
||
| const result = await php.run({ | ||
| code: `<?php | ||
| $out = shell_exec('/bin/echo hello_from_shell_exec'); | ||
| echo trim($out ?? 'NULL'); | ||
| `, | ||
| }); | ||
|
|
||
| expect(result.text).toBe('hello_from_shell_exec'); | ||
| }); | ||
|
|
||
| it('proc_open fails without spawn handler', async () => { | ||
| const result = await php.run({ | ||
| code: `<?php | ||
| $desc = [1 => ['pipe', 'w'], 2 => ['pipe', 'w']]; | ||
| $proc = @proc_open('echo test', $desc, $pipes); | ||
| echo is_resource($proc) ? 'OPENED' : 'FAILED'; | ||
| `, | ||
| }); | ||
|
|
||
| // Without a spawn handler, proc_open should fail | ||
| expect(result.text).toBe('FAILED'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.