Skip to content

HTML Processor: Ensure is_tag_closer is correctly called #6726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 3 commits into from
Closed

HTML Processor: Ensure is_tag_closer is correctly called #6726

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
615e387
Fix non-static method called statically
sirreal Jun 4, 2024
563c669
Fix call to parent is_tag_closer() should be $this
sirreal Jun 4, 2024
3af5fa9
Merge branch 'trunk' into fix/html-processor-fixes
dmsnell Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-includes/html-api/class-wp-html-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ public function next_tag( $query = null ) {
continue;
}

if ( ! $this::is_tag_closer() || $visit_closers ) {
if ( ! $this->is_tag_closer() || $visit_closers ) {
return true;
}
}
Expand Down Expand Up @@ -463,7 +463,7 @@ public function next_tag( $query = null ) {
continue;
}

if ( ! parent::is_tag_closer() || $visit_closers ) {
if ( ! $this->is_tag_closer() || $visit_closers ) {

@sirreal sirreal Jun 4, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmsnell This came up here: #6348 (comment)

I haven't been able to come up with a failing test case for it.

return true;
}
}
Expand Down