Skip to content

ESLint: Enable eslint-plugin-react-compiler #61788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyxla merged 11 commits into from
Nov 19, 2024
Merged

ESLint: Enable eslint-plugin-react-compiler #61788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
98bee5a
Add eslint-plugin-react-compiler beta as a dependency
tyxla Oct 22, 2024
90db587
Enable eslint-plugin-react-compiler rule
tyxla May 20, 2024
5aaafe1
Top-level await breaks eslint-plugin-react-compiler
tyxla May 20, 2024
5015f75
Disable all dev files
tyxla May 21, 2024
aad0597
Separate interactivity packages
tyxla May 21, 2024
6e58ce3
Use shorter ESLint plugin name
tyxla Aug 20, 2024
5bc01bf
Reformat
tyxla Aug 20, 2024
6bfdee7
Disable react-compiler for native files
tyxla Aug 21, 2024
26b60ea
Enable enableTreatRefLikeIdentifiersAsRefs babel env setting
tyxla Aug 21, 2024
eaa84d7
Disable validateRefAccessDuringRender
tyxla Oct 7, 2024
3bfdcd2
Move ESLint config outside of the eslint-plugin package
tyxla Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ module.exports = {
'plugin:eslint-comments/recommended',
'plugin:storybook/recommended',
],
plugins: [ 'react-compiler' ],
globals: {
wp: 'off',
globalThis: 'readonly',
Expand Down Expand Up @@ -222,6 +223,15 @@ module.exports = {
definedTags: [ 'jest-environment' ],
},
],
'react-compiler/react-compiler': [
'error',
{
environment: {
enableTreatRefLikeIdentifiersAsRefs: true,
validateRefAccessDuringRender: false,
},
},
],
},
overrides: [
{
Expand All @@ -236,6 +246,7 @@ module.exports = {
'import/no-unresolved': 'off',
'import/named': 'off',
'@wordpress/data-no-store-string-literals': 'off',
'react-compiler/react-compiler': 'off',
},
},
{
Expand Down Expand Up @@ -551,6 +562,7 @@ module.exports = {
{
files: [ 'packages/interactivity*/src/**' ],
rules: {
'react-compiler/react-compiler': 'off',
'react/react-in-jsx-scope': 'error',
},
},
Expand Down
65 changes: 65 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
"eslint-plugin-jest": "27.2.3",
"eslint-plugin-jest-dom": "5.0.2",
"eslint-plugin-prettier": "5.0.0",
"eslint-plugin-react-compiler": "19.0.0-beta-8a03594-20241020",
"eslint-plugin-ssr-friendly": "1.0.6",
"eslint-plugin-storybook": "0.6.13",
"eslint-plugin-testing-library": "6.0.2",
Expand Down