Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 The image based on 96b29032 commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches the SemanticDependencyUpdater (SDU) extension entry in
values.ymlfrom the WikiTeq fork (WikiTeq/SemanticDependencyUpdater, branchdeletion-hook-support@cd0f50a) to the origin repo gesinn-it-pub/SemanticDependencyUpdater, pinned to release 5.0.2 (commit4ab14606764cc321a6028fd191f6f3e021a59c0c).Why
The deletion-hook support that motivated our fork is integrated upstream: the
ArticleDeletedependency-rebuild hook is wired up as of 5.0.1 and documented in the upstream changelog (original PR #21 was closed, but the feature landed via follow-up work). We no longer need to track the fork.Jira: WIK-2388
Upstream verification
gesinn-it-pub/SemanticDependencyUpdater(default branchmaster)5.0.2resolves to commit4ab14606764cc321a6028fd191f6f3e021a59c0csrc/Hooks.php::onPageDelete()hooked onArticleDelete; CHANGELOG (5.0.1): "Register the page-deletion dependency rebuild hook (ArticleDelete, not PageDeleteComplete ...)"Validation
values.ymlparses cleanly (yaml.safe_load)values.schema.json(jsonschema)branch: masterkept because extension entries without abranchkey are cloned with-b $MW_VERSION(REL1_43), which does not exist in this repo; the build still pins the checkout to the 5.0.2 commit