Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Review follow-up: deploy-e2e now explicitly sets MAX_WAIT_SECONDS=600 to preserve its init margin; the test job keeps the new 300s fail-fast default. |
|
🐳 The image based on f85965d2 commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WIK-2504
Summary
The unbounded wait loop described in the ticket:
no longer exists verbatim on
master: it was already refactored into.github/scripts/wait-for-wiki-init.sh(commit d2aa7af), which implements exactly the deadline-based bounded wait the ticket asks for — a wall-clock deadline, a log-follower liveness check, and fail-fast detection of fatal bootstrap errors. It is used by both thetestanddeploy-e2ejobs in.github/workflows/docker-image.yml.However, its default timeout was still 600s (10 minutes), while the ticket asks for ~5 minutes. This PR changes the default:
The
MAX_WAIT_SECONDSenvironment variable override is preserved, so callers can still tune or extend the wait without code changes.Rationale
On init hangs, CI previously burned up to 10 minutes before failing; the ticket specifies ~5 minutes as a sensible bound. The script also prints the last 40 lines of streamed web logs on timeout, so failure diagnostics remain available well before any job-level GitHub Actions timeout would kill the run.
Test plan
bash -n .github/scripts/wait-for-wiki-init.shpasses.github/workflows/docker-image.yml(python3 -c "import yaml; yaml.safe_load(open(...))") passesNo other behavior is changed; unrelated code and the separate container-health wait loops are intentionally left untouched.