Allow to run setup scripts synchronously - #102
Open
vedmaka wants to merge 1 commit into
Open
Conversation
Adds new `FAST_BOOT` env. variable (enabled by default), if set to `0` will ensure all the setup and maintenance scripts are completed before starting Apache web server
|
🐳 The image based on 187dcb94 commit has been built with |
DanielButAtWork
suggested changes
Aug 28, 2023
| # Check and update permissions of wiki images in background. | ||
| # It can take a long time and should not block Apache from starting. | ||
| /update-images-permissions.sh & | ||
| if isTrue "$FAST_BOOT"; then |
There was a problem hiding this comment.
So overall this makes sense, but I suggest inverting the logic, since the default is that we want to boot fast - and also the name could be a bit clearer. Suggest something like
if isTrue "$SYNCHRONOUS_SCRIPTS"; then
/update-images-permissions.sh
else
/update-images-permissions.sh &
fi
and then having the default of SYNCHRONOUS_SCRIPTS be 0 instead of 1.
We should also update the comments to say that normally we shouldn't block Apache, but it can be configured to do so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new
FAST_BOOTenv. variable (enabled by default), if set to0will ensure all the setup and maintenance scripts are completed before starting Apache web server