fix MEDIAWIKI-CCY: Deduplicate block action IDs - #25
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a workaround for issue MEDIAWIKI-CCY, "UnexpectedValueException: Blockable action IDs not unique", which occurs when navigating to Special:Block.
The root cause is an incompatibility where the GlobalBlocking extension registers block action integer IDs that duplicate those already defined in MediaWiki 1.45.4's CORE_BLOCK_ACTIONS. The
BlockActionInfo::getAllBlockActionsmethod then throws an exception due to the non-unique IDs.To address this, a
GetAllBlockActionshook has been added toLocalSettings.php. This hook iterates through the combined list of block actions (core + extensions) and removes any duplicate integer IDs, prioritizing the first occurrence (typically from core). This prevents theUnexpectedValueExceptionand allows Special:Block to load.This is a temporary workaround. The long-term solution is to update the GlobalBlocking extension to a version that uses non-conflicting action IDs. Once that update is deployed, this hook should be removed.
Fixes MEDIAWIKI-CCY