Skip to content

Fix Column Reference #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattsonCam merged 6 commits into from
May 7, 2025
Merged

Fix Column Reference #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d53c372
Fixed bug by using correct columns and incremented version patch
May 7, 2025
1e286b5
Included dynamic tags in poetry
May 7, 2025
cd3a531
Removed change breaking the poetry install
May 7, 2025
051ebb6
Addressed pr comments by
May 7, 2025
b4491c5
Changed test to provide more coverage for similar bugs
May 7, 2025
8cbb4b2
Added PDV options and PDV inside the __init__.py files
May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "pairwise-compare"
version = "0.1.1"
version = "0.1.2"
Comment thread
MattsonCam marked this conversation as resolved.
Outdated
description = "Allows the user to compare groups of data specified in a tidy pandas dataframe with ease."
authors = ["Cameron Mattson <mattsoncameron1@gmail.com>"]
license = "BSD 3-Clause"
Expand Down
10 changes: 5 additions & 5 deletions src/comparison_tools/PairwiseCompare.py
View file
Open in desktop
Comment thread
MattsonCam marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ def __get_group_column_element(
else:
return _group_column_data

def __contains_match(self, _groups):
def __contains_match(self, _groups, _group_columns):
Comment thread
MattsonCam marked this conversation as resolved.
Outdated
"""Check if the same features between both groups are the same value."""

if not self.__one_different_comparison:
if len(self.__posthoc_group_cols) == 1:
if len(_group_columns) == 1:
if _groups[0] == _groups[1]:
return True

Expand All @@ -176,7 +176,7 @@ def inter_comparisons(self):
# Iterate through each ante group combination
for apair in apairs:

if self.__contains_match(apair):
if self.__contains_match(apair, self.__antehoc_group_cols):
continue

apair = tuple(
Expand Down Expand Up @@ -212,7 +212,7 @@ def inter_comparisons(self):
# Iterate through each well group cartesian product and save the data
for ppair in comparison_key_product:

if self.__contains_match(ppair):
if self.__contains_match(ppair, self.__posthoc_group_cols):
Comment thread
MattsonCam marked this conversation as resolved.
continue

ppair = tuple(
Expand Down Expand Up @@ -292,7 +292,7 @@ def intra_comparisons(self):
# Iterate through the combinations pairs of the groups
for ppair in comparison_key_combinations:

if self.__contains_match(ppair):
if self.__contains_match(ppair, self.__posthoc_group_cols):
continue

ppair = tuple(
Expand Down