-
Notifications
You must be signed in to change notification settings - Fork 6
chore(deployments): record Arbitrum + Base timelocks + docs generator #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"WCT":{"address":"0xeF4461891DfB3AC8572cCf7C794664A8DD927945","admin":"0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4","implementation":"0x4D1070C6e37de5870e11b99e2A006739e77ec5cb"},"chainId":42161} | ||
| {"Timelock":{"address":"0x8b8D9f03027004dB4b607E909246e9270D8fEdee"},"WCT":{"address":"0xeF4461891DfB3AC8572cCf7C794664A8DD927945","admin":"0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4","implementation":"0x4D1070C6e37de5870e11b99e2A006739e77ec5cb"},"chainId":42161} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 Auto Review Issue: Severity: LOW Context:
Recommendation: Reformat to match the other files (pretty-print with 2-space indent). This is also a prerequisite for the fix in Issue 1. No data classification issues found. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Auto Review Issue: Arbitrum WCT ProxyAdmin silently dropped from generated docs
Severity: MEDIUM
Category: correctness
Tool: Claude Auto Review
Context:
42161.jsonstores WCT proxy metadata at the top level ("admin": "0x3eD...","implementation": "0x4D1..."), while the docs generator (generate-deployment-docs.ts:152-159) only reads fromdeployment.proxy?.admin.8453.json(and theDeploymentEntryinterface) use the nestedproxysub-object."-"for the ProxyAdmin column of Arbitrum's WCT Token even though0x3eD030AAF23b5C22c224Cb72100C22f581D10Df4is the admin in the JSON.DEPLOYMENT_ADDRESSES.mdline| WCT Token | ... | - |is factually wrong — it hides who controls the WCT proxy upgrade on Arbitrum, reducing auditability and increasing the chance of a reviewer trusting the stale docs.pnpm run sync:deploymentsrun will reproduce the incorrect-value.Recommendation: Align
42161.jsonwith the schema used by every other deployment file:{ "Timelock": { "address": "0x8b8D9f03027004dB4b607E909246e9270D8fEdee" }, "WCT": { "address": "0xeF4461891DfB3AC8572cCf7C794664A8DD927945", "proxy": { "admin": "0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4", "implementation": "0x4D1070C6e37de5870e11b99e2A006739e77ec5cb", "type": "transparent" } }, "chainId": 42161 }Fix this →