Move LED config from user to confetti#103
Open
robertdijk wants to merge 2 commits into
Open
Conversation
LED color and pattern are now stored on the Confetti entity rather than the User. Removes the standalone LED page, adds LED fields to the confetti create/edit forms, and restricts LED API endpoints to the ledstrip scope. Confetti table and user picker now show stacked color dots. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the LED colour and pattern configuration into the confetti.
This way, the LEDs are synced with a user's confetti. This creates a better user experience with fewer, less overwhelming options. It also makes it more fun, since the same committee and transaction rules are applied.
Additionally, this PR tweaks the confetti selection screen a bit to showcase the LED/confetti colours.
It also updates the confetti admin screens: