Open
Conversation
enricozb
force-pushed
the
enricozb/playground
branch
2 times, most recently
from
0aed1f4 to
9b08707
Compare
enricozb
force-pushed
the
enricozb/playground
branch
8 times, most recently
from
8384c3e to
916f843
Compare
enricozb
force-pushed
the
enricozb/playground
branch
from
916f843 to
4e304d4
Compare
tjjfvi
reviewed
May 7, 2026
tjjfvi
reviewed
May 7, 2026
|
|
||
| arithmetic!(W0, W1, W2, W3, W4, W5, W6, W7, W8, W9, W10, W11, W12, W13, W14, W15, W16, W17, W18); | ||
|
|
||
| pub struct Arithmetic<E, WS>(E, PhantomData<fn() -> WS>); |
Member
There was a problem hiding this comment.
the changes required to this to support the HRTB for the registry are quite sad IMO; here's an alternative that avoids the HRTB: acda690
Contributor
Author
There was a problem hiding this comment.
I wasn't able to get the call-site of arithmetic to infer the R parameter, but otherwise this works.
Logic for loading modules for the Lsp is now external to the lsp crate. The playground (running on wasm) can't use `glob` for entrypoints, thus this change lets it provide its own `Loader` logic.
fixes lexer hangs on unterminated block comment
Only Compiler::nets_from instantiates templates, so storing a checkpoint after Compiler::check and using it for Compiler::nets_from resulted in a panic. This should probably be tracked by the Compiler internally anyways.
enricozb
force-pushed
the
enricozb/playground
branch
from
4e304d4 to
eb45a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.