feat(fields): add Mersenne31 circle domain skeleton - #310
Draft
adrienlacombe wants to merge 4 commits into
Draft
Conversation
Require logSize bounds on subgroupGen, document toPoint limitations, add toPoint/add_zero lemmas, and expand circle regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
- Rename `Point.add_zero` (proves `0 + p = p`) to `Point.zero_add` to match the repo's Mathlib-style naming convention. - Drop the discarded `logSize ≤ logOrder` argument from `CirclePointIndex.subgroupGen`; the body is total, and callers (`Coset.new`, `odds`, `halfOdds`) carry the bound where it is needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
🤖 PR SummaryStore the analysis in the variable Statistics
Lean Declarations ✏️ Added: 63 declaration(s)
📄 **Per-File Summaries**
Last updated: 2026-09-01 19:33 UTC. |
adrienlacombe
force-pushed
the
feat/mersenne31-circle-domain
branch
from
September 1, 2026 19:32
7fd8d61 to
11dd0ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a STWO-style circle-domain skeleton on top of the Mersenne31 field support merged in #257.
Changes
CompPoly.Fields.Mersenne31.Circle.x^2 + y^2 = 1.(2, 1268011823)and proves it lies on the circle.CirclePointIndexmodulo2^31, subgroup generator indices, cosets, conjugate cosets, circle domains, and canonical cosets.Non-goals
This intentionally does not prove that the generator has order
2^31, and it does not formalize FRI or circle polynomial evaluation. Those remain follow-on work after the domain skeleton stabilizes.Validation
lake build CompPoly.Fields.Mersenne31.Circle CompPolyTests.Fields.Mersenne31.Circlelake testlake buildlake exe axiomsweep --check./scripts/update-lib.sh./scripts/check-imports.sh./scripts/lint-style.shpython3 ./scripts/check-docs-integrity.pygit diff --check upstream/main..HEADAll checks pass under Lean v4.33.1.