-
Notifications
You must be signed in to change notification settings - Fork 3
Un 116 + UN-115 testing.md seeders, factories, etc #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PThorpe92
wants to merge
35
commits into
main
Choose a base branch
from
UN-116
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
d0ec640
feat: add ci/actions and fix migrations
PThorpe92 6b85d4a
fix: dependencies errors building
PThorpe92 785ce10
chore: migrate canvas utilities from other repository
b98a37c
fix: typo in canvasUtil
c39a3b7
fix: upgraded to meet schema
PThorpe92 beb0b33
fix: finish migration to schema
PThorpe92 79b9370
fix: naming issues in CanvasUtil
PThorpe92 6f85d20
fix: continued work
PThorpe92 8250662
fix: controller name
PThorpe92 d888c93
fix: refacotor boilerplate from canvasServices
PThorpe92 7ba9b8b
fix: discussed changes
PThorpe92 0ebf147
fix items in review with nokie. PR closes UN-102
PThorpe92 e325dc0
remove misnamed file, update api routes
PThorpe92 32f7408
final touches
PThorpe92 32fbec8
move to namespace
PThorpe92 0a17c36
fix: remove redundant files
PThorpe92 08793d6
fix: attempt to fix ci/package.lock
PThorpe92 c7b3628
fix: lots of merge conflicts
PThorpe92 73ec0e9
fix: lots and lots of stuff
PThorpe92 933682b
fix: change .github workflow to reflect cwd
PThorpe92 a248138
feat: add seeders/factories and testing.md
PThorpe92 7e92115
fix: finish seeders. we can now seed every Model for testing
PThorpe92 aeb3a0c
feat: work on making tests pass (still work to be done)
PThorpe92 c5f2082
feat: add a couple tests
PThorpe92 f4404e4
fix: many bugs
PThorpe92 3f69c1e
fix: work on tests
PThorpe92 efb8f9f
Fix student model needing HasUuids
nokierae 21b7c74
feat: work on tests
PThorpe92 85c79b2
fix: all but 2 tests
PThorpe92 4f8b8a3
fix: lockfile for build on ubuntu; tests still fail
PThorpe92 09ba771
major fixes/updates, many bugs fixed
b55bdd8
fix: add consumerProviderResource for ULv1
PThorpe92 f21e73b
fix: change to foreign UUID for student mapping constraint
PThorpe92 ac85dd5
fix: route issue and controller for platform_connections
PThorpe92 3594d92
feat: add platformConnection tests + fix surrounding issues
PThorpe92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| APP_NAME=Laravel | ||
| APP_ENV=local | ||
| APP_KEY=base64:UlGssQGrsDgLbYxxgWVAlVC6d/X22Ecr2W+GlqFK5i8= | ||
| APP_DEBUG=true | ||
| APP_URL=http://localhost | ||
|
|
||
| LOG_CHANNEL=stack | ||
| LOG_DEPRECATIONS_CHANNEL=null | ||
| LOG_LEVEL=debug | ||
|
|
||
| DB_CONNECTION=sqlite | ||
|
|
||
| BROADCAST_DRIVER=log | ||
| CACHE_DRIVER=file | ||
| FILESYSTEM_DISK=local | ||
| QUEUE_CONNECTION=sync | ||
| SESSION_DRIVER=database | ||
| SESSION_LIFETIME=120 | ||
|
|
||
| MEMCACHED_HOST=127.0.0.1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Build Laravel PHP Project | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["main"] | ||
|
|
||
| jobs: | ||
| phpunit: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: kirschbaumdevelopment/laravel-test-runner:8.2 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Install front-end dependencies | ||
| run: | | ||
| npm install | ||
| npm run build | ||
|
|
||
| - name: Install composer dependencies | ||
| run: | | ||
| composer update | ||
| composer install | ||
| - name: Prepare Laravel Application | ||
| run: | | ||
| cp .env.testing .env | ||
| php artisan migrate:fresh --env=testing | ||
|
|
||
| - name: Run Testsuite | ||
| run: php artisan test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,4 @@ yarn-error.log | |
| /.fleet | ||
| /.idea | ||
| /.vscode | ||
| D2L_api.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?php | ||
|
|
||
| namespace App\Enums; | ||
|
|
||
|
|
||
| enum PlatformConnectionType: string | ||
| { | ||
| case ENABLED = 'enabled'; | ||
| case DISABLED = 'disabled'; | ||
| case ARCHIVED = 'archived'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PThorpe92 in order to be able to return the requisite Provider Platform data (and Connection state) to the v.1 UI this needs to return the
ConsumerProviderResource::collectionthat was in the #3 request that you had integrated into your branch earlier when we collaborated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConsumerProviderResource?
The
showfunction you have in the link returnsSo because this is a
showfunction and you have specified theIDin the URL, it should return a collection of all that consumer platforms connections? that does make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Additionally it gets the
statevalue of the Platform Connection and adds that to the json Provider Platform (for that particular Consumer Platform) response data