new task scenes#63
Conversation
| # leading to high impact forces), the initial health values are not correct. | ||
| self.init_skip_steps = 4 # orginally 4 | ||
| # Per-task override (set via TaskConfig.post_playback_env_setup); defaults to 4. | ||
| self.init_skip_steps = getattr(self, "playback_init_skip_steps", 4) |
There was a problem hiding this comment.
Are 30 steps really needed for nav task? Are you sure?
There was a problem hiding this comment.
This is mainly for the pour water task I think. The playback video includes the part where the water glass gets filled, so I added this to skip that part. For the nav task I think we can go back to using the default
There was a problem hiding this comment.
If we can go back to using the default, let's do that. And then you can merge this PR yourself. Thanks!
| for remove_obj_name in cur_transitions["objects"]["remove"]: | ||
| obj = scene.object_registry("name", remove_obj_name) | ||
| scene.remove_object(obj) | ||
| if obj is None: |
There was a problem hiding this comment.
Do you get an error without this logic? Is this only for the wipe task?
There was a problem hiding this comment.
Yeah this fixes a playback error I get during wipe counter. So far I haven't noticed this code change affecting any other tasks
There was a problem hiding this comment.
Okay, let's keep this if it doesn't affect other tasks. Please playback a couple and make sure it indeed does not affect
2 participants
added new scenes