-
Notifications
You must be signed in to change notification settings - Fork 8
Make package description in metadata and README more generic #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,9 +25,9 @@ knitr::opts_chunk$set( | |
| [](https://joss.theoj.org/papers/b3d646dcf01299076e8a724ec8d909dc) | ||
| <!-- badges: end --> | ||
|
|
||
| `rmcmc` is an R package for simulating Markov chains using the Barker proposal | ||
| to compute _Markov chain Monte Carlo_ (MCMC) estimates of expectations with | ||
| respect to a target distribution on a real-valued vector space. | ||
| `rmcmc` is an R package for simulating Markov chains using random-walk, Langevin, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
| Hamiltonian or Barker proposals, to compute _Markov chain Monte Carlo_ (MCMC) | ||
| estimates of expectations with respect to a target distribution on a real-valued vector space. | ||
| The Barker proposal, described in [Livingstone and Zanella (2022)](https://doi.org/10.1111/rssb.12482), | ||
| is a gradient-based MCMC algorithm inspired by the Barker accept-reject rule. | ||
| It combines the robustness of simpler MCMC schemes, such as random-walk Metropolis, | ||
|
|
@@ -41,12 +41,22 @@ During an initial warm-up stage, the parameters of the proposal distribution can | |
| with adapters available to both: | ||
| tune the scale of the proposals by coercing the average acceptance rate to a target value; | ||
| tune the shape of the proposals to match covariance estimates under the target distribution. | ||
| As well as the default Barker proposal, the package also provides implementations of alternative proposal distributions, | ||
| such as (Gaussian) random walk and Langevin proposals. | ||
| Optionally, if [BridgeStan's R interface](https://roualdes.us/bridgestan/latest/languages/r.html), | ||
| available [on GitHub](https://github.com/roualdes/bridgestan), is installed, | ||
| [then BridgeStan can be used to specify the target distribution to sample | ||
| from](https://github-pages.ucl.ac.uk/rmcmc/articles/interfacing-with-stan-models.html). | ||
|
|
||
| The package has a modular design allowing different algorithmic components such | ||
| as proposals and adapters to be mixed and matched and to allow to it interface | ||
| with various existing packages: | ||
|
|
||
| - If [BridgeStan's R interface](https://roualdes.us/bridgestan/latest/languages/r.html), | ||
| available [on GitHub](https://github.com/roualdes/bridgestan), is installed, | ||
| [then BridgeStan can be used to specify the target distribution to sample from]( | ||
| https://github-pages.ucl.ac.uk/rmcmc/articles/interfacing-with-stan-models.html). | ||
| - The robust adaptive Metropolis algorithm described in [Vihola (2012)]( | ||
| https://doi.org/10.1007/s11222-011-9269-5) can be used for adapting the | ||
| proposal scale and shape if [the _ramcmc_ package]( | ||
| https://cran.r-project.org/web/packages/ramcmc/index.html) is installed. | ||
| - The generated chain output can be directly passed to functions for | ||
| computing summary statistics and convergence diagnostics in | ||
| [the _posterior_ package](https://mc-stan.org/posterior/). | ||
|
|
||
| ## Installation | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,11 @@ | |
| [](https://joss.theoj.org/papers/b3d646dcf01299076e8a724ec8d909dc) | ||
| <!-- badges: end --> | ||
|
|
||
| `rmcmc` is an R package for simulating Markov chains using the Barker | ||
| proposal to compute *Markov chain Monte Carlo* (MCMC) estimates of | ||
| expectations with respect to a target distribution on a real-valued | ||
| vector space. The Barker proposal, described in [Livingstone and Zanella | ||
| `rmcmc` is an R package for simulating Markov chains using random-walk, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment here, better not to focus so much on any specific algorithm |
||
| Langevin, Hamiltonian or Barker proposals, to compute *Markov chain | ||
| Monte Carlo* (MCMC) estimates of expectations with respect to a target | ||
| distribution on a real-valued vector space. The Barker proposal, | ||
| described in [Livingstone and Zanella | ||
| (2022)](https://doi.org/10.1111/rssb.12482), is a gradient-based MCMC | ||
| algorithm inspired by the Barker accept-reject rule. It combines the | ||
| robustness of simpler MCMC schemes, such as random-walk Metropolis, with | ||
|
|
@@ -32,15 +33,26 @@ acceptance rule. During an initial warm-up stage, the parameters of the | |
| proposal distribution can be adapted, with adapters available to both: | ||
| tune the scale of the proposals by coercing the average acceptance rate | ||
| to a target value; tune the shape of the proposals to match covariance | ||
| estimates under the target distribution. As well as the default Barker | ||
| proposal, the package also provides implementations of alternative | ||
| proposal distributions, such as (Gaussian) random walk and Langevin | ||
| proposals. Optionally, if [BridgeStan’s R | ||
| interface](https://roualdes.us/bridgestan/latest/languages/r.html), | ||
| available [on GitHub](https://github.com/roualdes/bridgestan), is | ||
| installed, [then BridgeStan can be used to specify the target | ||
| distribution to sample | ||
| from](https://github-pages.ucl.ac.uk/rmcmc/articles/interfacing-with-stan-models.html). | ||
| estimates under the target distribution. | ||
|
|
||
| The package has a modular design allowing different algorithmic | ||
| components such as proposals and adapters to be mixed and matched and to | ||
| allow to it interface with various existing packages: | ||
|
|
||
| - If [BridgeStan’s R | ||
| interface](https://roualdes.us/bridgestan/latest/languages/r.html), | ||
| available [on GitHub](https://github.com/roualdes/bridgestan), is | ||
| installed, [then BridgeStan can be used to specify the target | ||
| distribution to sample | ||
| from](https://github-pages.ucl.ac.uk/rmcmc/articles/interfacing-with-stan-models.html). | ||
| - The robust adaptive Metropolis algorithm described in [Vihola | ||
| (2012)](https://doi.org/10.1007/s11222-011-9269-5) can be used for | ||
| adapting the proposal scale and shape if [the *ramcmc* | ||
| package](https://cran.r-project.org/web/packages/ramcmc/index.html) is | ||
| installed. | ||
| - The generated chain output can be directly passed to functions for | ||
| computing summary statistics and convergence diagnostics in [the | ||
| *posterior* package](https://mc-stan.org/posterior/). | ||
|
|
||
| ## Installation | ||
|
|
||
|
|
@@ -128,4 +140,4 @@ results <- sample_chain( | |
| plot(results$traces[, "x"], results$traces[, "y"], col = "#1f77b4", pch = 20) | ||
| ``` | ||
|
|
||
| <img src="man/figures/README-banana-samples-1.png" width="100%" /> | ||
| <img src="man/figures/README-banana-samples-1.png" alt="" width="100%" /> | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest not mentioning specific algorithms here, broaden instead to simulating and comparing Markov chain algorithms, mention that we have these ones pre-coded but users can add others bla bla bla