forked from jgomezdans/gp_emulator
-
Notifications
You must be signed in to change notification settings - Fork 0
Review all code #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamespjh
wants to merge
120
commits into
reviewed
Choose a base branch
from
master
base: reviewed
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Review all code #35
Changes from all commits
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
261c59b
python C extension
sinanshi 4641ce6
establish gpu folder; Makefile; python ctype; (scratch)
sinanshi e543e3f
update the structure of the code and add one dummy global function cdist
sinanshi b5142b7
add matrix vector element wise multiplication
sinanshi 2d80a3e
update header file
sinanshi 71c5080
gpu_cdist() ready, but not verified
sinanshi ac83b4e
computeTranspose; matrix vector multiplication; some tests for debug;…
sinanshi fdac4a5
cdist 3D
sinanshi e7e7422
gpu exp function
sinanshi fe567ef
cunit test scaffolding
sinanshi 3f38212
tests of gpu vector times matrix
sinanshi a565a03
tests of cdist()
sinanshi 14808d1
test of matrixExp
sinanshi 1f9883d
remove debug
sinanshi aca9572
add cublasgemm tests
sinanshi 72b779d
to compute var
sinanshi 4b86d64
compute derivative
sinanshi a0bbb92
add output vectors to predict function
sinanshi 6fe7d98
working version 1
sinanshi c783529
first scratch cmake
sinanshi 2569497
adaptation to capability 2.0
sinanshi a42ee6f
new cmake with cookoff
sinanshi edc39e9
change cookoff file name
sinanshi 24a2eb6
1) adding loop in the kernels avoiding threads number exceeding. 2) b…
sinanshi ea03cc4
Merge branch 'master' of https://github.com/UCL/gp_emulator
sinanshi e24347c
loop implementation
sinanshi a0fb1ee
solve conflict
sinanshi 44eb74c
single precision
sinanshi 2d1466b
add cmake cookoff file
sinanshi 4ab4c67
N=1.8e6, blocksize=7
sinanshi 1aceb25
top level layout
sinanshi ccba736
cmake top level
sinanshi 7596569
cmake for testings;
sinanshi bb49bac
tests called by python; single precision implementation
sinanshi d9a9bef
fix the bug of cublasgemm
sinanshi cc23028
cmake
sinanshi 645c305
nvcc configure
sinanshi 6f7c5d5
cmake configured on Legion
sinanshi c609126
add correct python library
sinanshi fb6b6a7
reset unit testing path
sinanshi 570e509
tidyup; remove cdist function redundent argument D
sinanshi 515f626
commenting; modify cmake file
sinanshi d8989fa
free the memory properly
sinanshi a96aac2
benchmark tidy up
sinanshi 50f6264
add comments
sinanshi c11d17d
add output arguments to predict function; change computeTranspose
sinanshi b94a9ee
tidyup
sinanshi 1585f37
cope with python setup
sinanshi 2c48f02
change cmake directory
sinanshi e99ca3f
transfer back mu, var, deriv back to original python, error is around…
sinanshi 66160ef
is_gpu
sinanshi 38ebd91
test_perband
sinanshi 0481e2b
fix the bug of python calling C failure: input data has to be in 1 di…
sinanshi c1dd055
tidyup, unit_tests2
sinanshi 8612b1b
add comments
sinanshi 093fa1f
truncate input data
sinanshi f357cb5
remove redundent class GP and calling from GaussianProcess directely
sinanshi a49dd95
float and double precision check
sinanshi 4c7ee32
better truncate overcome the issue of last block being too small
sinanshi d463a40
tidyup
sinanshi 14ef519
kernel_vectorTimesMatrix
sinanshi 5433f21
remove benchmark2
sinanshi 5cc6033
add init_array, cdist kernel
sinanshi af07af9
add matrixExp
sinanshi 72e632f
add kernel: crossminux, elementwiseMult, matrixExp, rowSum, scalarMin…
sinanshi f2b20ac
modify python tests
sinanshi b35f1a9
correct type error of pow
sinanshi 3b4f651
remove matplotlib
sinanshi 1dc55fd
temproary remove matplotlib in multivariate
sinanshi d95f3d4
fix the bug of deriv
sinanshi 0d47196
tidy up; remove error message of predict
sinanshi 8f86055
tidyup
sinanshi fca0d0b
tidyup
sinanshi 16711db
tidyup
sinanshi b7c09ab
compare_result
sinanshi 7b31a93
tidyup
sinanshi 119b694
tidyup
sinanshi 03117f1
Update README.rst
sinanshi c478507
readme
sinanshi 91504d7
format readme
sinanshi 5f33dce
remove comments
sinanshi ff313dc
calling cmake via setup.py
sinanshi 0f2aa7e
setup include .so file
sinanshi 1491812
change prec to precision
sinanshi 8ebc3d6
change variable name
sinanshi f5586df
remove __main__
sinanshi 7f39469
modify get_gpu_block, add comments
sinanshi 7b5baca
change variable name
sinanshi 1a33679
better variable names predict.cu
sinanshi 248af97
breakdown distance calculation
sinanshi 3bf91cd
break down predict.cu blocks into functions
sinanshi daf90f9
correcting the error that compute_error is not called in last version
sinanshi eb4f09b
tidy up, change variable names, change macro to inline functions
sinanshi 775dfb7
char float64 to function np.float64
sinanshi 05858b4
c++ implementation of predict function
sinanshi 06a6931
finish c++ implementation header file
sinanshi c701bcf
tidyup
sinanshi decbaf0
reduce unit test iterations
sinanshi 25bbed1
free_gpu()
sinanshi df574fd
setup test
sinanshi d95dd9f
refactoring tests
sinanshi a7fa427
cpp -> cu
sinanshi 16924bd
remove _gpu_predict.c
sinanshi aa5ce51
setup benchmark and test
sinanshi 579e78b
Update README.rst
sinanshi b330d1f
fix setup.py benchmark
sinanshi a15e8f3
modifications for legion compilers, error_t has already been defined.
sinanshi 787fce0
deviceQuery for jenkins testing only
sinanshi dfaf578
traspose: ld_in -> lead_dim_in, etc.
sinanshi 313fa5d
change variables' name of kernels
sinanshi 902f85b
Merge branch 'master' of https://github.com/UCL/gp_emulator
sinanshi c0fb98a
remove print debug for cdist and crossmius
sinanshi b829ac0
tidy up
sinanshi ce5317b
correct typo
sinanshi c32e28c
typo
sinanshi f8ebde4
benchmark2: timing cpu times by operations
sinanshi 92f3460
print out properly
sinanshi 227276a
report
sinanshi 4f1fcd1
modification of report
sinanshi 5dddc08
restructuring cmake files, make double precision as an option
sinanshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| cmake_minimum_required (VERSION 2.8) | ||
|
|
||
| include(cmake/LookUp-GreatCMakeCookOff.cmake) | ||
| set(LIBRARY_OUTPUT_PATH ${CMAKE_SOURCE_DIR}/build/lib) | ||
| set(EXECUTABLE_OUTPUT_PATH ${CMAKE_SOURCE_DIR}/tests) | ||
| string(ASCII 27 Esc) | ||
|
|
||
| option(double "Enable testing" off) | ||
|
|
||
| if(double) | ||
| add_definitions(-DDOUBLE__PRECISION) | ||
| endif() | ||
|
|
||
|
|
||
| set(ColourReset "${Esc}[m") | ||
| set(Red "${Esc}[1;31m") | ||
| message("${Red}export PYTHONPATH=$PYTHONPATH:${LIBRARY_OUTPUT_PATH} ${ColourReset}") | ||
|
|
||
| find_package(Numpy REQUIRED) | ||
| find_package(CoherentPython REQUIRED) | ||
| find_package(CUDA QUIET REQUIRED) | ||
|
|
||
| find_library(FOUND_CUBLAS cublas) | ||
| include_directories(${PYTHON_INCLUDE_DIRS}) | ||
| include_directories(${NUMPY_INCLUDE_DIRS}/numpy) | ||
|
|
||
| set(CUBLAS_TARGET_LINK ${FOUND_CUBLAS}) | ||
|
|
||
| subdirs(gp_emulator/gpu) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| include setup.py README.rst | ||
| recursive-include gp_emulator/GaussianProcess.py __init__.py lhd.py multivariate_gp.py save_emulators.py | ||
| #recursive-include gp_emulator/ GaussianProcess.py __init__.py lhd.py multivariate_gp.py save_emulators.py | ||
| #include build/lib/_gpu_predict.so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Ignore everything in this directory | ||
| * | ||
| # Except this file | ||
| !.gitignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # This file is part of the GreatCMakeCookOff package and distributed under the MIT Licences. | ||
| # Upon inclusion in a cmake file, it will download the GreatCMakeCookOff and make itself known to | ||
| # CMake. It should be added explicitely to build systems that make use of recipes from the cook-off. | ||
| # And it should be included prior to using cook-off recipes: | ||
| # | ||
| # ```{CMake} | ||
| # include(LookUp-GreatCMakeCookOff) | ||
| # ``` | ||
|
|
||
|
|
||
| # First attempts to find the package | ||
| set(COOKOFF_DOWNLOAD_DIR "${PROJECT_BINARY_DIR}/external/src/GreatCMakeCookOff") | ||
| find_package(GreatCMakeCookOff NO_MODULE PATHS "${COOKOFF_DOWNLOAD_DIR}" QUIET) | ||
|
|
||
| # Otherwise attempts to download it. | ||
| # Does not use ExternalProject_Add to avoid doing a recursive cmake step. | ||
| if(NOT GreatCMakeCookOff_FOUND) | ||
| message(STATUS "[GreatCMakeCookOff] not found. Will attempt to clone it.") | ||
|
|
||
| # Need git for cloning. | ||
| find_package(Git) | ||
| if(NOT GIT_FOUND) | ||
| message(FATAL_ERROR "[Git] not found. Cannot download GreatCMakeCookOff") | ||
| endif() | ||
|
|
||
| # Remove GreatCMakeCookOff directory if it exists | ||
| if(EXISTS "${COOKOFF_DOWNLOAD_DIR}") | ||
| execute_process( | ||
| COMMAND ${CMAKE_COMMAND} -E remove_directory "${COOKOFF_DOWNLOAD_DIR}" | ||
| OUTPUT_QUIET | ||
| ) | ||
| endif() | ||
| if(NOT COOKOFF_GITREPO) | ||
| set(COOKOFF_GITREPO https://github.com/UCL/GreatCMakeCookOff.git) | ||
| endif() | ||
| execute_process( | ||
| COMMAND ${GIT_EXECUTABLE} clone "${COOKOFF_GITREPO}" | ||
| "${COOKOFF_DOWNLOAD_DIR}" | ||
| RESULT_VARIABLE CLONING_COOKOFF | ||
| OUTPUT_QUIET | ||
| ERROR_VARIABLE CLONING_ERROR | ||
| ) | ||
|
|
||
| if(NOT ${CLONING_COOKOFF} EQUAL 0) | ||
| message(STATUS "${CLONING_ERROR}") | ||
| message(FATAL_ERROR "[GreatCMakeCookOff] git cloning failed.") | ||
| else() | ||
| message(STATUS "[GreatCMakeCookOff] downloaded to ${COOKOFF_DOWNLOAD_DIR}") | ||
| find_package(GreatCMakeCookOff NO_MODULE PATHS "${COOKOFF_DOWNLOAD_DIR}" QUIET) | ||
| endif() | ||
|
|
||
| set(GreatCMakeCookOff_DIR "${COOKOFF_DOWNLOAD_DIR}/cmake") | ||
| set(GreatCMakeCookOff_FOUND TRUE) | ||
| endif() | ||
| unset(COOKOFF_DOWNLOAD_DIR) | ||
|
|
||
| # Adds GreatCMakeCookOff to module paths | ||
| initialize_cookoff() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Ignore everything in this directory | ||
| * | ||
| # Except this file | ||
| !.gitignore |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| pandoc report.md -o report.pdf -H report.latex |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| \let\oldlongtable\longtable | ||
| \def\longtable{\tiny \oldlongtable} | ||
| \usepackage[svgnames]{xcolor} | ||
| \usepackage{libertine} | ||
| \usepackage{framed} | ||
| \let\oldquote\quote | ||
| \let\endoldquote\endquote | ||
| \definecolor{verypalegreen}{RGB}{252,255,250} | ||
| \colorlet{shadecolor}{verypalegreen} | ||
|
|
||
| \makeatletter | ||
| \def\shadequote{\begin{snugshade}\begin{oldquote}} | ||
| \def\endshadequote{% | ||
| \end{oldquote}\end{snugshade}} | ||
| \makeatother | ||
| \renewenvironment{quote}{\begin{shadequote}}{\end{shadequote}} | ||
| \usepackage{lettrine} % Package to accentuate the first letter of the text | ||
| \usepackage{fix-cm} % Custom font sizes - used for the initial letter in the document | ||
|
|
||
| \definecolor{uclmidgreen}{RGB}{130,141,55} | ||
|
|
||
| \newcommand{\initial}[1]{ % Defines the command and style for the first letter | ||
| \lettrine[lines=3,lhang=0.3,nindent=0em]{ | ||
| \color{DarkGreen} | ||
| {\textsf{#1}}}{}} | ||
|
|
||
| \usepackage{sectsty} % Enables custom section titles | ||
| \sectionfont{\color{uclmidgreen} \usefont{OT1}{phv}{b}{n}} % Change the font of all section commands | ||
| \subsectionfont{\color{DarkSeaGreen} \usefont{OT1}{phv}{b}{n}} % Change the font of all section commands | ||
|
|
||
| \usepackage{titling} % Allows custom title configuration | ||
| \newcommand{\HorRule}{\color{DarkSeaGreen} \rule{\linewidth}{1pt}} % Defines the gold horizontal rule around the title | ||
|
|
||
| \pretitle{ | ||
| \vspace{-30pt} \begin{flushleft} \HorRule \fontsize{38}{38} \usefont{OT1}{phv}{b}{n} \color{uclmidgreen} \selectfont} % Horizontal rule before the title | ||
|
|
||
| \posttitle{\par\end{flushleft}\begin{flushleft}\fontsize{25}{25} \usefont{OT1}{phv}{b}{n} \color{Black} GPU acceleration of Gaussian process emulator\selectfont \end{flushleft}\vskip 0.5em } % Whitespace under the title and subtitle | ||
|
|
||
| \preauthor{\begin{flushleft}\large \lineskip 0.5em \usefont{OT1}{phv}{b}{sl} \color{uclmidgreen} Sinan Shi}% Author font configuration | ||
|
|
||
| \postauthor{\footnotesize \usefont{OT1}{phv}{m}{sl} \color{Black} % Configuration for the institution name | ||
|
|
||
|
|
||
| University College London% Your institution | ||
|
|
||
| \par\end{flushleft}\HorRule} % Horizontal rule after the title | ||
|
|
||
| \hypersetup{linkcolor=black} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Sinan, this is an example comment.