Repository navigation
feat(sdk): add host-facing authenticateMcpServer for OAuth MCP servers #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdityaxDeore
wants to merge
49
commits into
Twigpine:main
Choose a base branch
from
AdityaxDeore:feat/2294-sdk-mcp-oauth-authenticate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,686
−303
Open
Changes from 36 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
e4d4f24
feat(sdk): add host-facing authenticateMcpServer for OAuth MCP servers
AdityaxDeore f69b84c
fix(sdk): address CodeRabbit review on authenticateMcpServer (#2493)
AdityaxDeore 377c897
fix(sdk): address CodeRabbit round-2 review on authenticateMcpServer …
AdityaxDeore 672c580
fix(sdk): address CodeRabbit round-3 review on authenticateMcpServer …
AdityaxDeore 24f1088
test(sdk): cover the fence-after-settle and failed-reconnect outcomes…
AdityaxDeore 11cba9d
fix(sdk): address CodeRabbit round-4 review on authenticateMcpServer …
AdityaxDeore 129fb79
test(sdk): keep mocked init transparent to init.cache patches (#2493)
AdityaxDeore 4b5cb57
fix(skills): evict the cancelled skill-read result before a retry (#2…
AdityaxDeore 70e652e
fix(sdk): replace tools by exact server ownership in every auth outco…
AdityaxDeore ca6b111
fix(sdk): run pre-turn MCP work in the session's SDK context (#2493)
AdityaxDeore a77b7d8
fix(sdk): make the host's process-initialization wait abortable (#2493)
AdityaxDeore 72593d0
fix(sdk): capture the host flow's credential identity before initiali…
AdityaxDeore ec45081
fix(sdk): keep surviving shared discovery inside its originating cred…
AdityaxDeore 00c3ab9
fix(sdk): track live owners through the connection-cancellation lifec…
AdityaxDeore 20ffdd1
test(mcp): update XAA scope-entry counts for the P1 initial-reads sco…
AdityaxDeore 0a212e5
fix(sdk): satisfy typecheck for the abortable-init race and discovery…
AdityaxDeore 69c64de
chore(mcp): keep the acquire-id_token comment with its call (#2493)
AdityaxDeore b9008d8
fix(mcp): register the stalled stdio closer once the wrapper supplies…
AdityaxDeore bb8c622
Merge upstream main into feat/2294-sdk-mcp-oauth-authenticate
AdityaxDeore c8bfee5
Bind host reconnect discovery to the actual server connection
AdityaxDeore 8ec9d40
Replace a stale remote authenticate tool with the OAuth recovery tool
AdityaxDeore 80c20e8
Honor the session environment during host-triggered MCP setup
AdityaxDeore f0c3509
Describe host completion and next-turn status consistently
AdityaxDeore d4ff835
Keep a live reconnect waiter when the creator cancels before transpor…
AdityaxDeore 96e6e56
Release the correct connection after host cancellation / failed tool …
AdityaxDeore 6ecdee4
Keep surviving discovery requests in the originating credential names…
AdityaxDeore d6b5464
Add regression tests for the jatmn review round (PR #2493)
AdityaxDeore 4b44121
Fix CodeRabbit review round on PR #2493
AdityaxDeore 58c3dd4
Add regression tests for the CodeRabbit review round (PR #2493)
AdityaxDeore 0379acb
fix(mcp): record settled connects and adopt them synchronously (CodeR…
AdityaxDeore 55cb215
test(mcp): regression for settled-connect adoption vs release
AdityaxDeore 1c7c9d1
fix(sdk): snapshot session env, guard registration, fix win32 env del…
AdityaxDeore 851516f
test(sdk): regression tests for CodeRabbit #2493 reviews 5952738851 a…
AdityaxDeore de0cdd0
fix(sdk): address CodeRabbit review 5955577457 (join assertions, win3…
AdityaxDeore bbc2521
test(sdk): regression tests for CodeRabbit #2493 reviews 5956557301 a…
AdityaxDeore b992165
fix(sdk): address CodeRabbit review 5956557301 and Copilot 5955514041…
AdityaxDeore 8b4e5c4
test(sdk): regression tests for CodeRabbit #2493 review 5957362782 (r…
AdityaxDeore d9c8f10
fix(sdk): address CodeRabbit review 5957362782 (session-owned transpo…
AdityaxDeore 447c95a
fix(sdk): address CodeRabbit review 5961865068 (ownership-aware MCP c…
AdityaxDeore 10660a9
test(sdk): regression tests for CodeRabbit #2493 review 5961865068 (i…
AdityaxDeore 5094d4b
fix(sdk): address jatmn, CodeRabbit and CodeQL follow-ups on MCP auth
AdityaxDeore cfc54fc
test(sdk): regression tests for MCP auth review follow-ups
AdityaxDeore 9b7903c
fix(sdk): address CodeRabbit #2493 review 5966435933
AdityaxDeore e54aca1
Merge upstream/main into feat/2294-sdk-mcp-oauth-authenticate
AdityaxDeore 7c69566
test(sdk): strengthen abort-discovery and setup-join tests per CodeRa…
AdityaxDeore 0e94650
fix(sdk): honor host abort before installing MCP clients or submittin…
AdityaxDeore 3ee8b13
fix(sdk): address CodeRabbit #2493 review leftovers (reconnect owner …
AdityaxDeore 20eef78
fix(sdk): scope MCP task index by SDK client so one generation's fail…
AdityaxDeore ee9e433
fix(sdk): finalize a retired generation's tasks outside the cache gua…
AdityaxDeore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.