Revert d3-geo to 2.x to fix Node CJS consumers#3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building testing for the various consumer scenarios, it caught that the d3-geo upgrade from the @turf/buffer migration to TypeScript actually caused failures in node@18 from CJS. I believe this is because
d3-geoincorrectly points to an ESM file when it is expecting a CJS one. See arethetypeswrong with node16+cjs.The original upgrade was from d3-geo@1 to d3-geo@3, but d3-geo@2 hadn't yet been moved to ESM and so we can take that instead.
The failure that was caught by the consumer testing: