Fix #6929: relation map ignores selected autocomplete name#9104
Fix #6929: relation map ignores selected autocomplete name#9104Renatonet0 wants to merge 2 commits intoTriliumNext:mainfrom
Conversation
Previously, in the relation map, selecting an autocomplete option when specifying a relation name did not update the internal state. It incorrectly used the partially typed name instead of the selected one. This commit fixes the issue by dispatching an "input" event on 'blur' and 'Enter' keydown. This ensures that the final auto-completed value is properly synchronized and used as the relation name.
dosubot
bot
added
the
size:M
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug in the relation map where the selected autocomplete value for relation names was not being correctly captured. The fix ensures that the correct relation name is used by dispatching input events, and a unit test has been added to validate the fix. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the selected autocomplete value in the relation map was not being correctly used. The fix involves dispatching an 'input' event on 'blur' and 'Enter' keydown to ensure the value is synchronized. The changes are logical, and new unit tests have been added to cover the new behavior. My review includes a suggestion to refactor the new event handlers for better conciseness.
| export function setupAnswerEventHandlers($answer: JQuery<HTMLElement>) { | ||
| $answer.on("keydown", (e) => { | ||
| if (e.key === "Enter") { | ||
| $answer[0].dispatchEvent(new Event("input", { bubbles: true })); | ||
| } | ||
| }); | ||
|
|
||
| $answer.on("blur", () => { | ||
| $answer[0].dispatchEvent(new Event("input", { bubbles: true })); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The separate keydown and blur event handlers can be combined into a single, more concise handler by leveraging jQuery's ability to listen for multiple events at once. This makes the code more compact and idiomatic.
export function setupAnswerEventHandlers($answer: JQuery<HTMLElement>) {
$answer.on("keydown blur", (e) => {
if (e.type === "blur" || e.key === "Enter") {
$answer[0].dispatchEvent(new Event("input", { bubbles: true }));
}
});
}
eliandoran
left a comment
eliandoran
left a comment
There was a problem hiding this comment.
OK as a first implementation, although the long-term fix is to get rid of the jQuery and use a custom dialog.
The test is OK-ish, although I feel it's quite a bit complicated.
2 participants
Previously, in the relation map, selecting an autocomplete option when specifying a relation name did not update the internal state. It incorrectly used the partially typed name instead of the selected one.
This commit fixes the issue by dispatching an "input" event on 'blur' and 'Enter' keydown. This ensures that the final auto-completed value is properly synchronized and used as the relation name.
Additionally, a unit test was added to verify that the input events are correctly dispatched during these interactions.