Skip to content

web-clipper: prevent cloning when clipping to an existing note + optimizations #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
contributor wants to merge 6 commits into
base: main
Choose a base branch
from
Open

web-clipper: prevent cloning when clipping to an existing note + optimizations #8894

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ed313d
web-clipper: prevent questionable note cloning when clipping to an ex…
contributor Mar 3, 2026
e1a2dfe
chore: remove unused import
contributor Mar 8, 2026
5cc3bc7
chore: reconcile comment for addClipping with current implementation
contributor Mar 8, 2026
050cc68
avoid extra call when open web-clipper popup (use search service dire…
contributor Mar 8, 2026
2b592b2
avoid extra call to find clipper inbox when clipping to existing note
contributor Mar 8, 2026
9d71f9d
chore: clarify docstring for addClipping function
contributor Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/server/src/routes/api/clipper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ async function addClipping(req: Request) {

clippingNote.setContent(`${existingContent}${existingContent.trim() ? "<br>" : ""}${rewrittenContent}`);

// TODO: Is parentNoteId ever defined?
if ((clippingNote as any).parentNoteId !== clipperInbox.noteId) {
cloneService.cloneNoteToParentNote(clippingNote.noteId, clipperInbox.noteId);
}

return {
noteId: clippingNote.noteId
};
Expand Down
Loading