-
Notifications
You must be signed in to change notification settings - Fork 0
Regenerate header bindings for the current target instead of reusing incompatible x64 Windows bindings #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
29b09fa
generate bindings
maxded 6f93cdc
fix
maxded b8a971f
move into single workflow
maxded 8478459
fix cross job
maxded 974bfc9
fix..
maxded b3c8f82
generate bindings ci
maxded 339228c
on push
maxded e819cbe
fix syntax
maxded 82cace9
moar syntax
maxded 60afef8
add target
maxded 64b5b71
cross compile
maxded 440a22e
fix build.rs
maxded 5423a10
check
maxded 9b5adeb
Windows on windows
maxded 832a6de
add apple targets
maxded 5cb898d
remove pregenerated bindings
maxded 4ce62bc
fix bindings generation
maxded dea60a5
cleanup
maxded ba6c7c7
on push only
maxded 8749f3c
Merge branch 'main' into generate-bindings
maxded 803705e
remove armv7 test
maxded 7cfdd7c
update bindgen and force rust target
maxded 7f93635
remove rust target
maxded 5504041
Update src/lib.rs
maxded c640950
remvoe info.text
maxded 9226dea
Merge branch 'generate-bindings' of github.com:Traverse-Research/cpui…
maxded 524acd1
update docs
maxded 813c9a8
include 32bit targets
maxded ebabab4
add rust target to bindgen
maxded c5d8cd8
update proc-macro2 in minimal-versin check
maxded 147179a
Update Cargo.toml
maxded 4d17aae
feedback
maxded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| rust: | ||
|
|
@@ -14,8 +15,6 @@ jobs: | |
| run: cargo fmt --all -- --check | ||
| - name: Cargo clippy | ||
| run: cargo clippy --workspace --all-targets -- -D warnings | ||
| - name: Cargo test | ||
| run: cargo test --workspace | ||
|
Comment on lines
-17
to
-18
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed this test here as it is already covered by another build step for all targets. |
||
|
|
||
| rust-msrv: | ||
| name: Build-test MSRV (1.74) with minimal crate dependencies | ||
|
|
@@ -33,3 +32,84 @@ jobs: | |
| - uses: dtolnay/rust-toolchain@1.74.0 | ||
| - name: Cargo check | ||
| run: cargo check --workspace --all-targets | ||
|
|
||
| cross: | ||
| name: ${{ matrix.name }} (${{ matrix.target }}) | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| PROGRAM: ${{ matrix.cross && 'cross' || 'cargo' }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - target: x86_64-unknown-linux-gnu | ||
| os: ubuntu-latest | ||
| name: Linux | ||
| cross: false | ||
| test: true | ||
|
|
||
| - target: x86_64-apple-darwin | ||
| os: macos-latest | ||
| name: macOS | ||
| cross: false | ||
| test: true | ||
|
|
||
| - os: windows-latest | ||
| name: Windows | ||
| target: x86_64-pc-windows-msvc | ||
| cross: false | ||
| test: true | ||
|
|
||
| # - os: ubuntu-latest | ||
| # name: FreeBSD | ||
| # target: x86_64-unknown-freebsd | ||
| # cross: true | ||
| # test: false | ||
|
maxded marked this conversation as resolved.
|
||
|
|
||
| - target: aarch64-linux-android | ||
| os: ubuntu-latest | ||
| name: Android | ||
| cross: true | ||
| test: true | ||
|
|
||
| # - os: ubuntu-latest | ||
| # name: OpenWrt | ||
| # target: aarch64-unknown-linux-gnu | ||
| # cross: true | ||
| # test: true | ||
| # cargo_args: --features "openwrt" | ||
|
maxded marked this conversation as resolved.
|
||
|
|
||
| - target: armv7-unknown-linux-gnueabihf | ||
| os: ubuntu-latest | ||
| name: Linux ARMv7 | ||
| cross: true | ||
| test: true | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - name: Bootstrap | ||
| uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| targets: ${{ matrix.target }} | ||
|
|
||
| - name: Install cross | ||
| run: cargo install cross | ||
| if: ${{ matrix.cross }} | ||
|
|
||
| - name: Build | ||
| run: ${{ env.PROGRAM }} build --target=${{ matrix.target }} ${{ matrix.cargo_args }} | ||
|
|
||
| - name: Test | ||
| run: ${{ env.PROGRAM }} test --target=${{ matrix.target }} ${{ matrix.cargo_args }} | ||
| if: ${{ matrix.test }} | ||
|
|
||
| - name: Run example | ||
| run: cargo run --example info | ||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: info-${{ matrix.target }} | ||
| path: info.txt | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| /target | ||
| /Cargo.lock | ||
| info.txt | ||
| info.txt | ||
|
maxded marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the
pull_requestone as it would trigger our CI jobs twice which isn't needed.