Add openelm adapter tests#1383
Open
chandrudp29 wants to merge 3 commits into
Open
Conversation
Covers config attributes (rotary positional embeddings, parallel attn/mlp, no prepend BOS), component mapping bridge types and HF module names, all 7 weight conversion keys with shared source key validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers config attributes (RMS norm, rotary embeddings, gated MLP, LLaMA-2 tokenizer proxy), component mapping bridge types and HF module names, and verifies weight_processing_conversions is empty (native attention handles all per-layer dimension variants internally). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for OpenElmArchitectureAdapter as part of the test backfill effort in #1302.
Covers:
BlockBridge, AttentionBridgewith combined QKV (qkv_proj), MLPBridge with ffn/proj_1/proj_2 naming, RMSNormalizationBridge with OpenELM-specific norm namesweight_processing_conversionsis empty (native HF attention handles all per-layer dimension variants)All 33 tests pass locally.
Type of change
Checklist