Remove eps_attr config field#1379
Merged
jlarson4 merged 1 commit intoJun 11, 2026
Merged
Conversation
Breaking: removes the public eps_attr constructor argument and the config.eps_attr attribute. The field was never read (its consumer was deleted when NormalizationBridge moved to direct HF delegation), so no model behavior changes, but it is an API removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1376.
Removes the unused
eps_attrfield fromTransformerBridgeConfig. It was set by 8 architecture adapters but read nowhere (its only consumer was deleted in #1119 whenNormalizationBridgemoved to direct HF delegation), so removing it changes no model behavior.It is a breaking API change: the
eps_attrconstructor argument and theconfig.eps_attrattribute are gone (the field was live, never deprecated). Serialized configs are unaffected (from_dictdrops unknown keys). The break only hits code that passeseps_attr=to the constructor or readsconfig.eps_attr.Removed in one sweep: the config field, the 8 adapter
self.cfg.eps_attr = ...assignments, the 6 adapter-test assertions, and the doc/template mentions (including the now-deadcfg.eps_attrtroubleshooting row in the numerical-divergence guide).Note: deleted the troubleshooting row rather than rewire it, since the eps machinery already auto-introspects
.eps/.variance_epsilon(a transformers 5.8.1 scan found no HF norm using another attribute name), so the symptom is not user-actionable via this field.Type of change
Checklist: