Skip to content

Fix app version parsing - #36

Merged
GianniCarlo merged 1 commit into
mainfrom
fix/second-onboarding-app-version-undefined
Jul 18, 2026
Merged

Fix app version parsing#36
GianniCarlo merged 1 commit into
mainfrom
fix/second-onboarding-app-version-undefined

Conversation

@GianniCarlo

Copy link
Copy Markdown
Contributor

No description provided.

@GianniCarlo GianniCarlo self-assigned this Jul 18, 2026
@github-actions

Copy link
Copy Markdown

✅ Claude PR Review — PASS

This PR fixes an unhandled 500 on POST /v1/user/second_onboarding where semver.gte(app_version, minVersion) threw Invalid version when older clients omitted or malformed app_version. It introduces a meetsMinVersion helper that guards with semver.valid() before comparing, and applies it at both call sites in secondOnboarding/handleDefaultOnboarding. A regression test covering the missing-app_version case was added. The change is defensive-only and does not affect auth-middleware coverage, authorization scoping, IAP/passkey validation, or data access; no security or layering concerns in the changed lines.

Findings: no findings

Model claude-opus-4-8 · run log · 0 new · 0 carried over · 0 resolved · advisory (a human should still review). Duplicate findings are de-duplicated and stale ones auto-resolved across pushes.

@GianniCarlo
GianniCarlo merged commit 29de28d into main Jul 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant