Skip to content

Handle edge case when last event is not null - #35

Merged
GianniCarlo merged 1 commit into
mainfrom
fix/second-onboarding-500-null-lastevent
Jul 18, 2026
Merged

Handle edge case when last event is not null#35
GianniCarlo merged 1 commit into
mainfrom
fix/second-onboarding-500-null-lastevent

Conversation

@GianniCarlo

Copy link
Copy Markdown
Contributor

No description provided.

@GianniCarlo GianniCarlo self-assigned this Jul 18, 2026
@github-actions

Copy link
Copy Markdown

✅ Claude PR Review — PASS

PR #35 is a targeted bugfix + cleanup. The core fix adds a lastEvent != null guard in UserController.handleDefaultOnboarding (secondOnboarding flow) to stop a production 500 when a SECOND_ONBOARDING_SKIP exists but its START event was never recorded; return types in UserDB.getLastUserEvent/UserServices.getLastUserEvent were made nullable to match, and a regression test was added. The error middleware's swapped req/res parameter types were corrected and 5xx errors now log method/url/stack at error level (no sensitive fields exposed). The /v1/storage router and StorageController were removed; no remaining code references them (only stale entries in CLAUDE.md docs). No authorization-scoping, auth-middleware, IAP, passkey, secret, or SQL-injection concerns arise from these changes. Note: CLAUDE.md still documents the now-removed Storage routes and should be updated, but that file isn't touched by this PR.

Findings: no findings

Model claude-opus-4-8 · run log · 0 new · 0 carried over · 0 resolved · advisory (a human should still review). Duplicate findings are de-duplicated and stale ones auto-resolved across pushes.

@GianniCarlo
GianniCarlo merged commit 4d55932 into main Jul 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant