Repository navigation
perf(state): derive n_systems from cell shape to avoid GPU-CPU sync - #621
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimState.n_systemsfrom the leading dimension ofcellinstead oftorch.uniqueonsystem_idx, so reading it no longer forces a GPU-CPU sync.state.n_systemsin the FIRE steps, as discussed in PERF: Remove GPU-CPU Synchronization in FIRE #609.__post_init__batches the cell, so system constraint bounds are checked against the correctn_systemswhen a(3, 3)cell is passed. Add a test for this case.Checklist
Before a pull request can be merged, the following items must be checked: