Skip to content

fix: Make grpc usable with C++ #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rustybee42 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Make grpc usable with C++ #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,27 @@ SRC_DIR := proto
# Output directory for compiled Go files
GO_OUT_DIR := go
# Output directory for compiled C++ files
CPP_OUT_DIR := cpp
CPP_OUT_DIR := cpp/include/proto
# Output directory for compiled Rust files
RUST_OUT_DIR := rust

# grpc install directory
GRPC_INSTALL_DIR := $(HOME)/.local/grpc

all: protos

.PHONY: protos
protos: check-tools
mkdir -p $(GO_OUT_DIR) $(CPP_OUT_DIR) $(RUST_OUT_DIR)
protoc -I $(SRC_DIR) \
$(GRPC_INSTALL_DIR)/bin/protoc -I $(SRC_DIR) \
--go_opt=module="github.com/thinkparq/protobuf/go" \
--go_opt=default_api_level=API_HYBRID \
--go_out=$(GO_OUT_DIR) \
--go-grpc_opt=module="github.com/thinkparq/protobuf/go" \
--go-grpc_out=$(GO_OUT_DIR) \
--cpp_out=$(CPP_OUT_DIR) \
--grpc_out=$(CPP_OUT_DIR) \
--plugin=protoc-gen-grpc=$(GRPC_INSTALL_DIR)/bin/grpc_cpp_plugin \
$(SRC_DIR)/*.proto
protoc-rs -I $(SRC_DIR) --out=$(RUST_OUT_DIR) $(SRC_DIR)/*.proto

Expand Down Expand Up @@ -54,7 +59,7 @@ clean:


# The tools versions we want to use
PROTOC_VERSION := 29.2
PROTOC_VERSION := 31.1
PROTOC_GEN_GO_VERSION := 1.36.2
PROTOC_GEN_GO_GRPC_VERSION := 1.5.1
PROTOC_RS_VERSION := 0.6.0
Expand All @@ -64,7 +69,7 @@ PROTOC_RS_VERSION := 0.6.0
.ONESHELL: check-tools
check-tools:
@function check() { [[ "$$1" == "$$2" ]] || { echo "tool version mismatch: expected $$1, got $$2" ; exit 1 ; } }
check "libprotoc $(PROTOC_VERSION)" "$$(protoc --version)"
check "libprotoc $(PROTOC_VERSION)" "$$($(GRPC_INSTALL_DIR)/bin/protoc --version)"
check "protoc-gen-go v$(PROTOC_GEN_GO_VERSION)" "$$(protoc-gen-go --version)"
check "protoc-gen-go-grpc $(PROTOC_GEN_GO_GRPC_VERSION)" "$$(protoc-gen-go-grpc --version)"
check "protoc-rs $(PROTOC_RS_VERSION)" "$$(protoc-rs --version)"
Expand All @@ -85,10 +90,8 @@ install-tools:

(
set -x
# protoc
curl -LfsSo /tmp/protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOC_VERSION)/protoc-$(PROTOC_VERSION)-linux-$${ARCH}.zip
rm -rf "$${HOME}/.local/bin/protoc" "$${HOME}/.local/include/google/protobuf"
unzip -o -q -d "$${HOME}/.local" /tmp/protoc.zip "bin/protoc" "include/google/protobuf/*"
# grpc installation
# TODO: do an automatic clone and install here or require to do it manually?
# other tools
GOBIN="$${HOME}/.local/bin" go install google.golang.org/protobuf/cmd/protoc-gen-go@v$(PROTOC_GEN_GO_VERSION)
GOBIN="$${HOME}/.local/bin" go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v$(PROTOC_GEN_GO_GRPC_VERSION)
Expand Down
Loading
Loading