Removes Either dependency.#610
Conversation
|
Oh, shoot, I just realized that I forgot to write documentation for the new enums. Let me do that real quick before merge. |
|
Oh, and |
|
I should probably mention: This PR conflicts with #607. I didn't realize that until after I made the PR. For some reason I thought that it had already been merged, so I didn't think there would be a conflict. |
|
Any update on this? I'd like to start work on the next PR. |
|
I won't be able to look at this until the end of the week |
|
Alright, I've got a side project I'm working on anyway, so no rush. |
|
Thanks! |
Description
Eithertends to make code a little harder to read, and a little harder to write, so I decided it would be a good idea to remove the dependency entirely and instead rely on tailored enums to do the job.Related Issue
#609
How This Has Been Tested
All tests passed for all supported versions of LLVM on Windows.
Option<Breaking Changes>
Breaking changes for readability.
Checklist
(I ran cargo clippy this time, hopefully github actions doesn't complain anyway)