Skip to content

Fix empty input edge case and correct output formatting #14444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximSmolskiy merged 7 commits into from
Apr 10, 2026
+5 −1
Merged

Fix empty input edge case and correct output formatting #14444

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b67591
Fix empty input edge case and correct output formatting
mahema-14 Mar 25, 2026
7b231a4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 25, 2026
a31a022
Merge branch 'master' into fix-pigeonhole-bug
mahema-14 Mar 26, 2026
7268d28
Update pigeonhole_sort.py
MaximSmolskiy Apr 10, 2026
7456a84
Update pigeonhole_sort.py
MaximSmolskiy Apr 10, 2026
f605cfa
Update pigeonhole_sort.py
MaximSmolskiy Apr 10, 2026
bf4ddd0
Merge branch 'master' into fix-pigeonhole-bug
MaximSmolskiy Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sorts/pigeonhole_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ def pigeonhole_sort(a):
>>> a == b
True
"""
if not a:
return # this handles empty list
# size of range of values in the list (ie, number of pigeonholes we need)

min_val = min(a) # min() finds the minimum value
Expand Down Expand Up @@ -38,7 +40,7 @@ def pigeonhole_sort(a):
def main():
a = [8, 3, 2, 7, 4, 6, 8]
pigeonhole_sort(a)
print("Sorted order is:", " ".join(a))
print("Sorted order is:", " ".join(map(str, a))) # it converts integer into string


if __name__ == "__main__":
Expand Down