Skip to content

seva-launcher: add support for docker compose v2#16

Merged
cshilwant merged 1 commit into
TexasInstruments:mainfrom
yogeshhegde:fix-docker-compose
Jul 10, 2026
Merged

seva-launcher: add support for docker compose v2#16
cshilwant merged 1 commit into
TexasInstruments:mainfrom
yogeshhegde:fix-docker-compose

Conversation

@yogeshhegde

Copy link
Copy Markdown
Collaborator

Docker compose v2 is built-in to the docker command and is not a script like docker compose v1 and the command invocation also changed from docker-compose to docker compose. Patch adds this feature so that seva-laucher can work with docker compose v2.

@yogeshhegde
yogeshhegde force-pushed the fix-docker-compose branch 2 times, most recently from e0a6c8e to ed98b26 Compare April 12, 2026 06:59
@yogeshhegde
yogeshhegde force-pushed the fix-docker-compose branch from ed98b26 to 95045f9 Compare July 8, 2026 07:42
@yogeshhegde
yogeshhegde marked this pull request as ready for review July 8, 2026 07:42
Comment thread seva-launcher/seva-compose.go Outdated
Docker compose v2 is built-in to the docker command and is not a script
like docker compose v1 and the command invocation also changed from
docker-compose to docker compose. Patch adds this feature so that
seva-laucher can work with docker compose v2.

Signed-off-by: Yogesh Hegde <y-hegde@ti.com>
@yogeshhegde
yogeshhegde force-pushed the fix-docker-compose branch from 95045f9 to a34cd8b Compare July 8, 2026 09:58
@jeevantelukula

Copy link
Copy Markdown

Also, I would suggest to return the args prefix from func prepare_compose() instead of just the binary name. Something like a small helper that prepends ["docker", "compose"] or ["docker-compose"] based on what was detected. During calling, we can just do exec.Command(composeArgs("-p", "seva-launcher", "up", "-d")...) uniformly without needing the if else checks in three places. Helps for future version changes in docker compose.

@yogeshhegde
yogeshhegde force-pushed the fix-docker-compose branch 2 times, most recently from 58f7b62 to a34cd8b Compare July 8, 2026 10:54
@cshilwant
cshilwant merged commit 16a1e4f into TexasInstruments:main Jul 10, 2026
2 checks passed
@yogeshhegde
yogeshhegde deleted the fix-docker-compose branch July 10, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants