Conversation
- `data/novel/build.gradle.kts`: Retrofit, Paging, Serialization 등 의존성 설정 및 Android 라이브러리 모듈 환경 구성 - `settings.gradle.kts`: 전체 프로젝트 구성 내 `:data:novel` 모듈 추가 - `data/novel/src/main/AndroidManifest.xml`: 라이브러리 구성을 위한 기본 매니페스트 파일 추가
- `NovelSearchEntity.kt`: 작품 ID, 제목, 작가, 이미지 URL 정보를 포함하는 `NovelSearchEntity` 데이터 클래스 정의
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
data:novel모듈을 추가했습니다.GET /novels작품 검색 API를 정의하고query,page,size파라미터를 전달하도록 구현했습니다.NovelSearchPagingSource를 구현했습니다.isLoadable값을 기준으로 다음 페이지 요청 여부를 결정합니다.LoadResult.Error로 전달하도록 구현했습니다.data:novel모듈을 등록하고 Network, Paging, Retrofit 및 Serialization 의존성을 연결했습니다.검증
./gradlew :data:novel:compileDebugKotlin ktlintCheck --console=plaindata:novel모듈 Debug 컴파일 성공📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
GET /novels의 요청 파라미터와 응답 모델 매핑을 확인 부탁드립니다.isLoadable을 기준으로 다음 페이지 키를 결정하는 Paging 로직을 확인 부탁드립니다.PagingSource는params.loadSize를 API의size로 전달하며, 구체적인 Pager 설정과 화면 연결은 다음 PR에 포함됩니다.feat/937feat/938