사이드네비게이션 모바일 디자인 수정 - #573
Merged
Merged
Conversation
|
🚀 storybook url: https://689bfce92a7bd08f5aa1edbe-syqqyrcshl.chromatic.com/ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughStorybook 전역에 React Query Provider를 적용했다. 모바일 사이드 내비게이션에 드로어 포커스 관리, Escape 닫기, 백드롭, inert 본문 처리를 추가했다. 메뉴와 채팅 항목 선택 시 모바일 내비게이션을 닫도록 변경했다. 페이지 높이를 부모 기준으로 통일하고 overscroll 전파를 제한했다. 버튼 속성 우선순위, 모달 스크롤, Popover 위치 갱신과 접근성 라벨 처리도 변경했다. Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/`(dev)/mock-chat/MockChatPage.tsx:
- Line 147: 모바일 스크롤 컨테이너인 해당 div에 h-full 클래스를 추가하세요. 기존 flex-1 및 overflow 설정은
유지하여 모바일에서도 컨테이너가 부모 높이를 채우고 내부 세로 스크롤이 생성되도록 하세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 03457b89-7e23-4c44-9beb-d9397673363e
📒 Files selected for processing (30)
.storybook/preview.ts.storybook/withQueryClient.tsxsrc/app/(dev)/mock-chat/MockChatPage.tsxsrc/app/(route)/all-link/AllLink.tsxsrc/app/(route)/chat/[id]/ChatPage.tsxsrc/app/(route)/home/HomePage.tsxsrc/app/(route)/home/loading.tsxsrc/app/(route)/mypage/Mypage.tsxsrc/app/layout-client.tsxsrc/app/layout.tsxsrc/app/loading.tsxsrc/components/basics/Button/Button.tsxsrc/components/basics/IconButton/IconButton.tsxsrc/components/basics/Modal/Modal.style.tssrc/components/basics/Popover/Content.tsxsrc/components/basics/Popover/Trigger.tsxsrc/components/basics/Popover/hooks/usePopoverPosition.tssrc/components/layout/SideNavigation/SideNavigation.tsxsrc/components/layout/SideNavigation/components/Bottom/SideNavigationBottom.tsxsrc/components/layout/SideNavigation/components/ChatRoomSection/ChatItem.tsxsrc/components/layout/SideNavigation/components/ChatRoomSection/ChatRoomSection.tsxsrc/components/layout/SideNavigation/components/Header/SideNavigationHeader.tsxsrc/components/layout/SideNavigation/components/MenuSection/MenuSection.tsxsrc/components/layout/SideNavigation/components/NavItem/LinkNavItem.tsxsrc/components/layout/SideNavigation/components/SideNavModals.tsxsrc/components/wrappers/LinkCardDetailPanel/LinkCardDetailPanel.style.tssrc/hooks/util/useCloseSideNavOnSelect.tssrc/hooks/util/useIsMobile.tssrc/stories/SideNavigation.stories.tsxsrc/styles/globals.css
Bangdayeon
force-pushed
the
design/#568-mobile-sidenavigation
branch
from
August 11, 2026 03:31
a51983d to
5e3c329
Compare
|
🚀 storybook url: https://689bfce92a7bd08f5aa1edbe-jzhteotqml.chromatic.com/ |
Merged
Seong-Myeong
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 설명
tertiary_neutral)같이 고친 부수 버그
prop인 ariaLabel을 넘기고, 두 컴포넌트가 {...rest}를 aria-label={ariaLabel} 뒤에 펼쳐서 덮어씀. 값이 있을 때만 주입하도록 수정 + 두 컴포넌트의 스프레드 순서
정리
호이스팅
하나의 effect로 정리하고 에 inert를 걸어 실제 focus trap 확보. Esc도 패널 onKeyDown(포커스가 안에 있을 때만 동작) → document 레벨 useEscKeyPress로 이동
ariaLabel(기존엔 전부 동일한 이름), aria-current, prefetch={false}(채팅 수십 개 일괄 prefetch 방지)
교체. maximum-scale=1은 복원 안 함 (확대 차단은 WCAG 1.4.4 위반)
상태. 전역 데코레이터 추가 + 앱 셸 래퍼 + 데스크톱 확장/축소, 모바일 열림/닫힘, 짧은 뷰포트 5개 스토리로 확장