Skip to content

fix(opd): score teacher logprobs at rollout temperature, not 0 #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EazyReal wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(opd): score teacher logprobs at rollout temperature, not 0 #2085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion slime/rollout/on_policy_distillation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ async def reward_func(args, sample, **kwargs):
# "text": sample.prompt + sample.response,
"input_ids": sample.tokens,
"sampling_params": {
"temperature": 0,
# Score teacher log-probs at rollout_temperature: SGLang scales
# input_token_logprobs by the sampling temperature, and the student
# log-probs are temperature-scaled too (get_responses), so the OPD KL is
# only consistent when both are at the same temperature.
"temperature": getattr(args, "rollout_temperature", 1.0),
"max_new_tokens": 0,
"skip_special_tokens": False,
},
Expand Down
Loading