Skip to content

Improve passing correct duration for THEOads #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorisfluyt wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve passing correct duration for THEOads #66

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be4ec6
Use ad duration with return type double
jorisfluyt Jul 1, 2025
4154d86
Tweak
MattiasBuelens Apr 16, 2026
e330618
Fix typo
MattiasBuelens Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/conviva/src/main/java/com/theoplayer/android/connector/analytics/conviva/utils/Utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ fun updateAdMetadataForGoogleIma(ad: GoogleImaAd, metadata: ConvivaMetadata): Co
fun collectAdMetadata(ad: Ad): ConvivaMetadata {
// AssetName should never be an empty string
return mutableMapOf(
ConvivaSdkConstants.DURATION to if (ad is LinearAd) ad.duration else 0,
ConvivaSdkConstants.DURATION to if (ad is LinearAd) ad.durationAsDouble else 0.0,
Comment thread
MattiasBuelens marked this conversation as resolved.
Outdated
ConvivaSdkConstants.ASSET_NAME to ad.id,

// [Required] This Ad ID is from the Ad Server that actually has the ad creative.
Expand Down
Loading