Feat(client): CardList 컴포넌트 구현 #284
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { style } from '@vanilla-extract/css'; | ||
|
|
||
| const THREE_COLUMN_MIN_WIDTH = '1060px'; | ||
| const MEMO_LIST_CONTAINER = 'memoList'; | ||
|
|
||
| const columns = (count: number) => `repeat(${count}, minmax(34rem, 38rem))`; | ||
|
|
||
| export const memoListContainer = style({ | ||
| width: '100%', | ||
| containerType: 'inline-size', | ||
| containerName: MEMO_LIST_CONTAINER, | ||
| }); | ||
|
|
||
| export const memoListGrid = style({ | ||
| display: 'grid', | ||
| gridTemplateColumns: columns(2), | ||
| justifyContent: 'safe center', | ||
| gap: '2rem', | ||
|
|
||
| '@container': { | ||
| [`${MEMO_LIST_CONTAINER} (min-width: ${THREE_COLUMN_MIN_WIDTH})`]: { | ||
| gridTemplateColumns: columns(3), | ||
| }, | ||
| }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import Card from '@shared/components/card/card'; | ||
| import { components } from '@shared/types/schema'; | ||
|
|
||
| import * as styles from './memo-list.css'; | ||
|
|
||
| type CardType = components['schemas']['MemoDashboardResponse']; | ||
|
|
||
| interface MemoListProps { | ||
| cards: CardType[]; | ||
| isSelected: boolean; | ||
| isDragging: boolean; | ||
| onClickCard: () => void; | ||
| } | ||
|
|
||
| const MemoList = ({ | ||
| cards, | ||
| isSelected, | ||
| isDragging, | ||
| onClickCard, | ||
| }: MemoListProps) => { | ||
| return ( | ||
| <div className={styles.memoListContainer}> | ||
| <div className={styles.memoListGrid}> | ||
| {cards.map((card) => ( | ||
| <Card | ||
| key={card.memoId} | ||
| card={{ | ||
|
Comment on lines
+25
to
+27
Member
There was a problem hiding this comment. 행님 이곳에 isNew가 누락된 것 같습니다. isNew를 심폐소생술로 부활시켜야할 것 같다데스⚔️ |
||
| tagList: card.tagList, | ||
| title: card.title ?? '', | ||
| content: card.content ?? '', | ||
| fileCount: card.fileCount ?? 0, | ||
| imageCount: card.imageCount ?? 0, | ||
| createAt: card.createdAt ?? '', | ||
| }} | ||
|
Comment on lines
+27
to
+34
Collaborator
There was a problem hiding this comment. props로 보내는게 많아져서 card 객체를 통째로 보내고 |
||
| isSelected={isSelected} | ||
| isDragging={isDragging} | ||
| onClick={onClickCard} | ||
| /> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default MemoList; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { useEffect, useRef } from 'react'; | ||
| import { type FetchNextPageOptions } from '@tanstack/react-query'; | ||
|
|
||
| // 바닥에 닿기 전에 미리 불러와 로딩을 기다리는 구간을 없앤다 | ||
| const LOAD_MORE_ROOT_MARGIN = '200px'; | ||
|
|
||
| interface UseInfiniteScrollProps { | ||
| hasNextPage: boolean; | ||
| isFetchingNextPage: boolean; | ||
| fetchNextPage: (options?: FetchNextPageOptions) => void; | ||
| } | ||
|
|
||
| /** | ||
| * 목록 끝에 둔 요소가 화면에 들어오면 다음 페이지를 불러오는 무한 스크롤 훅 | ||
| * | ||
| * | ||
| * @param hasNextPage - false면 관측하지 않는다 | ||
| * @param isFetchingNextPage - 패칭 중에는 관측을 멈춘다. 패칭이 끝나면 옵저버를 | ||
| * 다시 만들어 관측 요소가 계속 보이는 상태에서도 다음 페이지가 이어진다 | ||
| * @param fetchNextPage - cancelRefetch 기본값(true)은 진행 중인 요청을 취소하고 | ||
| * 재시작하므로 false로 넘겨 호출한다 | ||
| * @returns 목록 마지막에 배치할 요소의 ref | ||
| */ | ||
| export const useInfiniteScroll = ({ | ||
| hasNextPage, | ||
| isFetchingNextPage, | ||
| fetchNextPage, | ||
| }: UseInfiniteScrollProps) => { | ||
| const loadMoreRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| useEffect(() => { | ||
| const loadMoreTarget = loadMoreRef.current; | ||
| if (!loadMoreTarget || !hasNextPage || isFetchingNextPage) return; | ||
|
Collaborator
There was a problem hiding this comment. p4) 인지 관점에서 아래 코드처럼 하는 것도 깔끔해져요! if (!loadMoreTarget) return;
if (!hasNextPage) return;
if (isFetchingNextPage) return; |
||
|
|
||
| const observer = new IntersectionObserver( | ||
| ([entry]) => { | ||
| if (entry?.isIntersecting) fetchNextPage({ cancelRefetch: false }); | ||
| }, | ||
| { rootMargin: LOAD_MORE_ROOT_MARGIN }, | ||
| ); | ||
| observer.observe(loadMoreTarget); | ||
|
|
||
| return () => observer.disconnect(); | ||
| }, [hasNextPage, isFetchingNextPage, fetchNextPage]); | ||
|
|
||
| return loadMoreRef; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| import { style } from '@vanilla-extract/css'; | ||
|
|
||
| export const container = style({ | ||
| width: '100%', | ||
| paddingInline: '4rem', | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것은 뭔밍 정말 처음봐요 안전한 센터 참 신기하네요