chore: tup-621 migrate css to core-styles - news - #325
Closed
wesleyboar wants to merge 58 commits into
Closed
Conversation
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
14 tasks
* feat: tup-619 c-content block migration * removed content-block import
* migrated c-update to core-styles * removed c-update import
* feat: tup-624: added generics/attributes to demo * migrated rest of attributes.css to core-styles * removed unnecessary comments in css file for c-button
* getting rid of django.cms.blog.app.item.css * removing the import for django.cms.blog.app.item.css
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
WARNING: v2.17.3 causes login form field bug.
No need for u-highlight per jira ticket Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod * remove import of core-styles o-heading-steps.css
* chore: tup-463 remove temp. core-styles imports Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet. Now CMS has much more recent Core-Styles, so use them. Do not duplicate. * chore: tup-463 delete css modules mimicking core Some Core-Styles CSS was added after TUP login form was developed. Now that it is available, TUP lofin form can use it. Less module CSS! * style: npx nx format:write
Some Core-Styles CSS was added after TUP login page was developed. Now that it is available, TUP login page can use it. Less module CSS!
3 tasks
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Jul 31, 2026
## Overview Update `tup/html/` with every snippet change from a currently-open tup-ui PR. ## Related - requires #559 - migrates snippet changes from: - TACC/tup-ui#568 - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - TACC/tup-ui#566 ## Changes - **added** `embed-vislab-*.html` <sup>latest versions from:</sup> - TACC/tup-ui#568 - **updated** `css-ad-hoc-styles.html` <sup>hand-composed from:</sup> - TACC/tup-ui#325 - TACC/tup-ui#535 - TACC/tup-ui#557 - TACC/tup-ui#562 - TACC/tup-ui#565 - **updated** `js-ad-hoc-scripts.html` <sup>hand-composed from:</sup> - TACC/tup-ui#535 - TACC/tup-ui#566 ## Testing 1. Compare `embed-vislab-*` files against the branch of TACC/tup-ui#568 to confirm content matches. 2. For `css-ad-hoc-styles.html` and `js-ad-hoc-scripts.html`, compare against each contributing PR's diff to confirm every intended change made it in.
wesleyboar
force-pushed
the
task/tup-463-migrate-some-css-to-core-styles
branch
from
August 3, 2026 20:07
e899a68 to
af092c1
Compare
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 3, 2026
…pment (#561) ## Overview Migrates `c-news.css`, `c-news--read.css`, and `c-news--list.css` out of [TACC/tup-ui's `for-core-styles/` folder](https://github.com/TACC/tup-ui/tree/v1.2.3/apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles). <details> These are genuine Core-Styles gaps discovered while building tup-ui — not tup-specific overrides — so this repo's `generic_assets/` (not `tup/`) is the right home, since it's what other projects actually check for known Core-Styles/Core-CMS gaps. </details> ## Related - adds to #563 - required by tup-ui#570 Includes changes from: - TACC/tup-ui#325 Does not include `c-feed-list.css` cuz it is deleted in: - TACC/tup-ui#325 - TACC/tup-ui#535 ## Changes - **added** `generic_assets/css/c-news.css` - **added** `generic_assets/css/c-news--read.css` - **added** `generic_assets/css/c-news--list.css` - **added** `generic_assets/css/core-styles-feats.css` (imports `c-news.css` into `layer(base)`, since a plain `<link>` can't assign a layer) - **updated** `tup/html/css-ad-hoc-styles.html` to load `core-styles-feats.css`, instead of adding another raw `<style>@import>` block to an already-large snippet ## Testing 1. Confirm each file's content matches tup-ui's current `for-core-styles/components/` copy, with tup-ui#325's diff applied to `c-news.css` and `c-news--read.css`. <!-- ## Notes … -->
c-news.css and c-news--read.css: migrated to Core-CMS-Custom with this PR's edits composed in (TACC/Core-CMS-Custom#561, merged). c-feed-list.css, c-feed-list-tweaks.css, and tup-cms.for-core-styles.css: this PR's deletions/edits to these are already done independently in tup-ui#570 and #571.
Member
Author
|
Closing because zero changes since abe2a31 because #570, #571, and TACC/Core-CMS-Custom#561 (merged) — everything this PR did is now covered elsewhere. |
jarosenb
pushed a commit
that referenced
this pull request
Aug 10, 2026
* chore(cms): delete snippets migrated to Core-CMS-Custom These 9 template copies were reference-only records of djangocms-snippet content per this repo's "Save Snippets" convention. They now live in Core-CMS-Custom (TACC/Core-CMS-Custom#559) with no open PR here still editing them, so the local copies are redundant. * chore(cms): delete remaining snippets migrated to Core-CMS-Custom css-ad-hoc-styles.html and js-ad-hoc-scripts.html were held back from the prior commit because open PRs (#325, #535, #557, #562, #565, #566) still edited them here. Those PRs are being updated to drop their edits to these two files in favor of Core-CMS-Custom (TACC/Core-CMS-Custom#560), so the local copies can go too. * chore(cms): delete redirect.html and open-external-post.html Unlike this PR's other deletions, these two were never migrated to Core-CMS-Custom (they're djangocms-snippet "template"-field templates, not manually-synced reference copies, per the original migration's notes). They're deleted here because #535 already deletes them independently — the external-post-link and redirect behavior they provide is now handled by Core-CMS itself.
jarosenb
added a commit
that referenced
this pull request
Aug 10, 2026
* chore(cms): delete ad-hoc CSS files migrated to Core-CMS-Custom The actual asset files these snippets link to are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564, sub-PR of #563) instead of here. These were reference-only copies (per this repo's "Save Snippets" convention). navbar-width-horz-scrollbar.css and c-feed-list-tweaks.css are included even though tup-ui#535/#325 also touch them: their edits (trim, delete) are already reflected in Core-CMS-Custom#564. js/ad-hoc.js and js/ad-hoc/prevent-ugly-urls.js are held back — tup-ui#566 has a pending edit to ad-hoc.js not yet reverted, so deleting it now would conflict. * chore(cms): delete ad-hoc JS files migrated to Core-CMS-Custom Same as this PR's CSS deletions: these are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here. tup-ui#566 (closed) had a pending edit to ad-hoc.js; it was reverted to zero diff and closed before this, so no conflict here. --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrate CSS to TACC/Core-Styles.
Important
Old, but still relevant. Revisit after merging #535.
To Do
Related
Changes
c-newsto match recent changes to Core-CMS's Django CMS Blog CSSthis is temporary record keeping; migration will remove these files from
tup-cmsTesting
UI
…
Notes
Note
Reverted this PR's edit to
css-ad-hoc-styles.html— that snippet is now versioned in Core-CMS-Custom and is being deleted from this repo in #569.