Skip to content

enable ruff checks; resolve ruff errors - #1360

Open
rstijerina wants to merge 2 commits into
task/WP-1256--format-server-side-codefrom
task/WP-1256--enable-ruff-checks
Open

enable ruff checks; resolve ruff errors#1360
rstijerina wants to merge 2 commits into
task/WP-1256--format-server-side-codefrom
task/WP-1256--enable-ruff-checks

Conversation

@rstijerina

Copy link
Copy Markdown
Member

Overview

Enables ruff code checks, and resolves existing issues. Ran poetry run ruff check --fix.

Ruff has a ruleset to enforce PEP guidelines as well as some organizational standards like import sorting (isort) which is what is changed in this PR. Replaces Flake8.

Does not include any functional changes.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.30189% with 138 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.50%. Comparing base (f094322) to head (790e81c).

Files with missing lines Patch % Lines
server/portal/apps/accounts/models.py 6.66% 14 Missing ⚠️
...erver/portal/apps/googledrive_integration/views.py 42.85% 8 Missing ⚠️
server/portal/libs/agave/models/permissions.py 0.00% 7 Missing ⚠️
...s/projects/management/commands/migrate-projects.py 0.00% 6 Missing ⚠️
...l/apps/projects/management/commands/projects_id.py 0.00% 6 Missing ⚠️
...workspace_operations/shared_workspace_migration.py 0.00% 6 Missing ⚠️
server/portal/apps/users/utils.py 60.00% 6 Missing ⚠️
server/portal/libs/agave/models/applications.py 0.00% 6 Missing ⚠️
server/portal/apps/projects/managers/base.py 50.00% 5 Missing ⚠️
.../apps/workspace/management/commands/import_apps.py 0.00% 5 Missing ⚠️
... and 41 more
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           task/WP-1256--format-server-side-code    #1360      +/-   ##
=========================================================================
- Coverage                                  56.53%   56.50%   -0.03%     
=========================================================================
  Files                                        534      534              
  Lines                                      17153    17143      -10     
  Branches                                    3496     3494       -2     
=========================================================================
- Hits                                        9697     9687      -10     
- Misses                                      6906     6907       +1     
+ Partials                                     550      549       -1     
Flag Coverage Δ
javascript 58.59% <ø> (ø)
unittests 54.36% <78.30%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/apps/accounts/api/urls.py 100.00% <ø> (ø)
server/portal/apps/accounts/api/views/systems.py 29.62% <100.00%> (ø)
server/portal/apps/accounts/managers/abstract.py 85.71% <ø> (ø)
server/portal/apps/accounts/managers/accounts.py 82.05% <ø> (ø)
...er/portal/apps/accounts/migrations/0001_initial.py 100.00% <100.00%> (ø)
.../accounts/migrations/0002_hostkeys_keys_sshkeys.py 100.00% <100.00%> (ø)
server/portal/apps/accounts/urls.py 100.00% <100.00%> (ø)
server/portal/apps/auth/api/urls.py 100.00% <100.00%> (ø)
server/portal/apps/auth/api/views.py 100.00% <100.00%> (ø)
server/portal/apps/auth/backends.py 91.66% <100.00%> (ø)
... and 172 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sophia-massie sophia-massie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to test everything is working, I pushed keys to Expanse, Vista, and Bridges. Ran app on bridges. Can login/logout. Ran ruff checks. LGTM!

@edmondsgarrett edmondsgarrett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants