task/WI-472: Created view for collecting reports on content-security-policy violations. - #1349
Draft
fnets wants to merge 3 commits into
Draft
task/WI-472: Created view for collecting reports on content-security-policy violations.#1349fnets wants to merge 3 commits into
fnets wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
+ Coverage 64.09% 64.17% +0.08%
==========================================
Files 461 464 +3
Lines 13793 13880 +87
Branches 2750 2771 +21
==========================================
+ Hits 8841 8908 +67
- Misses 4603 4618 +15
- Partials 349 354 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a view to receive and log Content-Security-Policy violation reports sent by browsers, in support of the report-only CSP rollout (see companion nginx PR below).
Related
Changes
Created view for collecting reports on content-security-policy violations. Accepts POST only, and logs it via a dedicated csp_reports logger, and always returns 204. Malformed requests are logged and still return 204.
Testing
curl -X POST /csp-report/returns 204 and the payload appears in container logs.django.urls.resolve('/csp-report/')that this view (not the CMS catch-all) is what's actually served.POST.Notes
The
csp-report/pattern must stay abovecms.urlsin the include order. During testing, having it below the catch-all caused requests to silently forward tocms.views.detailsinstead of this view.