Skip to content

feat: update core-styles from v2.11 to v2.22 - #742

Merged
wesleyboar merged 14 commits into
mainfrom
feat/core-styles-v2-19-0
Nov 28, 2023
Merged

feat: update core-styles from v2.11 to v2.22#742
wesleyboar merged 14 commits into
mainfrom
feat/core-styles-v2-19-0

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Nov 3, 2023

Copy link
Copy Markdown
Member

Overview

Update Core-Styles from v2.11 to v2.20.

Status

Important

See tasks on TACC/tup-ui#344.

Related

Changes

Core-CMS

Core-Styles

  • v2.12.0 through v2.22.0

Testing

  1. Form styles should remain unchanged.
  2. s-affixed-input-wrapper use cases should be unchanged.
    No use cases on CMS's that use Core-Styles v2.
  3. feat: tup-463 migrate css to core tup-ui#344

UI

Skipped.

@wesleyboar
wesleyboar marked this pull request as ready for review November 3, 2023 23:41
@wesleyboar wesleyboar changed the title feat: update Core-Styles from v2.11 to v2.19 feat: update Core-Styles from v2.11 to v2.20 Nov 13, 2023
@wesleyboar wesleyboar added the priority ▲ High priority label Nov 14, 2023
@wesleyboar wesleyboar changed the title feat: update Core-Styles from v2.11 to v2.20 feat: update Core-Styles from v2.11 to v2.21 Nov 16, 2023
@wesleyboar wesleyboar changed the title feat: update Core-Styles from v2.11 to v2.21 feat: update Core-Styles from v2.11 to v2.22 Nov 22, 2023
* feat: bump core-styles & use its django-cms-forms

Core-Styles v2.15 provides django-cms-forms via `core-styles.base.css`.

Core-Styes v12–14 do not include any breaking changes.

* feat: load django-cms-forms.css from core-styles

Core-Styles loads shared form styles via c-form.

Those shared styles to apply to Django CMS Forms.

But django-cms-forms.css has specific custom styles CMS needs.

* fix: django-cms-forms.css (core-styles ~2.22.1)

* fix: django-cms-forms.css (core-styles) not built

* docs: fix djangocms_forms comment/redirect typo

* Revert "fix: django-cms-forms.css (core-styles) not built"

This reverts commit c07ec5b.

* fix: django-cms-forms.css (core-styles) not built
@wesleyboar wesleyboar changed the title feat: update Core-Styles from v2.11 to v2.22 feat: update core-styles from v2.11 to v2.22 Nov 27, 2023
* fix: cms button styles not applied to form buttons

* fix: limit most button styles to main content

* fix: core-styles v2.22.0 to v2.22.1

* fix: core-styles django cms form button class name

* chore: core-styles v2.22.1 to v2.22.2
Comment thread taccsite_cms/static/djangocms_forms/css/djangocms_forms.css Outdated
@wesleyboar
wesleyboar merged commit a989be0 into main Nov 28, 2023
@wesleyboar
wesleyboar deleted the feat/core-styles-v2-19-0 branch November 28, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority ▲ High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant