Skip to content

Update success rate check #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finestructure merged 2 commits into from
Apr 16, 2026
+3 −4
Merged

Update success rate check #4037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6ae03
Update success rate check
finestructure Apr 16, 2026
839819b
Update test
finestructure Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/App/Commands/Alerting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,7 @@ extension [Alerting.BuildInfo] {

func validateSuccessRateInRange() -> Alerting.Validation {
let successRate = Double(filter { $0.status == .ok }.count) / Double(count)
// Success rate has been around 30% generally
if 0.15 <= successRate && successRate <= 0.45 {
if 0.15 <= successRate && successRate <= 0.85 {
return .ok
} else {
let percentSuccessRate = (successRate * 1000).rounded() / 10
Expand Down
4 changes: 2 additions & 2 deletions Tests/AppTests/AlertingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ extension AllTests.AlertingTests {
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 14.9% out of bounds"]))
}
do {
let okCount = 451
let okCount = 851
let failedCount = 1000 - okCount
let okBuilds = (0..<okCount).map { _ in Alerting.BuildInfo.mock(status: .ok) }
let failedBuilds = (0..<failedCount).map { _ in Alerting.BuildInfo.mock(status: .failed) }
let all = okBuilds + failedBuilds
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 45.1% out of bounds"]))
#expect(all.validateSuccessRateInRange() == .failed(reasons: ["Global success rate of 85.1% out of bounds"]))
}
}

Expand Down
Loading