Repository navigation
ci: run operations-agent:contracts:check in the contracts gate - #578
Merged
SwayingWindmill merged 1 commit intoOct 17, 2026
Merged
Conversation
The check verifies the generated Agent Session client against its OpenAPI contract, but no gate ran it: contracts:check does not cover operationsAgentSessions.gen.ts, so the client could drift unnoticed. Register it in contracts.core next to contracts:check.
SwayingWindmill
deleted the
ci/register-operations-agent-contracts-check
branch
October 17, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operations-agent:contracts:checkverifiesapps/hvac-web/src/api/generated/operationsAgentSessions.gen.tsagainstcontracts/http/operations-agent-sessions-public.openapi.json, but no gate ran it —contracts:check(generate-platform-contracts.mjs) does not cover this file, so the generated Agent Session client could drift from its contract unnoticed. Register it in the shared contracts profile so every domain that runscontracts.core(includingoperations-agent) checks it.contracts.core npm run contracts:check + npm run operations-agent:contracts:check npm run ownership:check ...Evidence
node scripts/run-domain-task.mjs --domain=operations-agent --layers=contracts --dry-run=truelists nooperations-agent:contracts:check.After: the plan lists
npm run operations-agent:contracts:checkright afternpm run contracts:check.7cf446f8):npm run operations-agent:contracts:check→Operations Agent Session generated contract is current.npm run pr:gates:test→ 21/21 pass.Merge Danger
Door: two-way
Blast Radius: gates
Adds one fast, dependency-free node check to every contracts gate run; it fails only if the generated client is stale.