Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly expands the SwanLab SDK's internal API layer, introducing new modules for experiment management, project operations, user/API key handling, and self-hosted deployment features. It includes new functions for experiment heartbeats, state updates, and metrics retrieval, along with corresponding type definitions and utility functions. Review feedback highlights a discrepancy between the type hint and docstring for the experiment metrics key, as well as a missing return type hint in the self-hosted user retrieval function.
d3503f3 to
85392d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description