Skip to content

Fix intermittent startup crash on Windows: honor disableHttpsFeatures in Welcome Tab #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SatyamAgarwl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix intermittent startup crash on Windows: honor disableHttpsFeatures in Welcome Tab #1905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/robomongo/gui/widgets/workarea/WelcomeTab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,41 @@
#include <QtWebEngineWidgets>
#include <QDesktopServices>

#include "robomongo/core/AppRegistry.h"
#include "robomongo/core/settings/SettingsManager.h"

namespace Robomongo {

// ------------------ WelcomeTab
WelcomeTab::WelcomeTab(QScrollArea *parent) :
QWidget(parent), _parent(parent)
{
auto mainLayout = new QHBoxLayout;
mainLayout->setContentsMargins(-10, -10, -1, -1);
mainLayout->setSizeConstraint(QLayout::SetMinimumSize);
setLayout(mainLayout);

// Respect "disableHttpsFeatures" on Windows/macOS as well (it already
// gates the Welcome Tab menu action and the Linux implementation).
// Creating any WebEngine object starts the embedded Chromium, which
// intermittently crashes the whole application shortly after startup
// on newer Windows builds (access violation in Qt5WebEngineCore.dll).
// With this setting enabled the web view is never created, so the
// embedded Chromium never initializes.
if (AppRegistry::instance().settingsManager()->disableHttpsFeatures())
return;

auto webView = new QWebEngineView(this);
QUrl const URL {
"http://files.studio3t.com/rm-feed_3t_io/1.4.3/index.html"
"http://files.studio3t.com/rm-feed_3t_io/1.4.3/index.html"
};
webView->setPage(new MyWebPage(this));
webView->page()->setUrl(URL);
webView->setContextMenuPolicy(Qt::NoContextMenu);
webView->page()->triggerAction(QWebEnginePage::WebAction::ReloadAndBypassCache);
webView->page()->profile()->setHttpCacheType(QWebEngineProfile::HttpCacheType::NoCache);

auto mainLayout = new QHBoxLayout;
mainLayout->setContentsMargins(-10, -10, -1, -1);
mainLayout->setSizeConstraint(QLayout::SetMinimumSize);
mainLayout->addWidget(webView);
setLayout(mainLayout);
}

// ------------------ MyWebPage
Expand Down