Fix: resolve issues #580, #579, #578, #577 - #638
Open
colemaya95-ctrl wants to merge 4 commits into
Open
Conversation
The reset timeout was not cancelled on unmount, causing React to warn about state updates on unmounted components. Now uses useEffect cleanup to clear the timeout. Closes Stellar-split#578
StatusBadge now displays a tooltip on hover and keyboard focus with a descriptive sentence for each status. Descriptions are stored in the STATUS_CONFIG and configurable via the description prop. The tooltip is accessible via both mouse hover and keyboard focus. Closes Stellar-split#577
Adds comprehensive tests to verify that matched query substrings are properly highlighted in GlobalSearch result items, including invoice IDs, titles, creator addresses, and recipient addresses. Matching is case-insensitive as expected. Closes Stellar-split#579
CommandPalette now shows keyboard shortcuts next to commands when they are registered in the ShortcutRegistry. Shortcuts are displayed in right-aligned kbd elements with visually distinct styling. Commands without bindings show no shortcut hint. Closes Stellar-split#580
|
@colemaya95-ctrl is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@colemaya95-ctrl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements fixes and enhancements for 4 issues:
Test Plan
Closes #580
Closes #579
Closes #578
Closes #577