Skip to content

test: handle TMPDIR symlinks #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stebalien merged 1 commit into from
May 7, 2026
+14 −5
Merged

test: handle TMPDIR symlinks #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions tests/namedtempfile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,21 @@ fn test_temp_path_resolve_existing_cwd() {
let tmpdir = tempdir().unwrap();
std::env::set_current_dir(&tmpdir).expect("failed to change to directory");

let cwd = if cfg!(target_os = "macos") {
// MacOS has absolute paths and ABSOLUTE paths. `cd /var/tmp/...` actually changes to
// /private/var/tmp...
std::env::current_dir().expect("failed to get the current directory")
// Check relative to the directory we actually ended up in, not `tmpdir`,
// as there may be symlinks in the path.
let cwd = std::env::current_dir().expect("failed to get the current directory");

// Make sure we actually ended up in the right place.
if let (Ok(canonical_cwd), Ok(canonical_tmpdir)) =
(cwd.canonicalize(), tmpdir.path().canonicalize())
{
// We canonicalize the paths because `std::env::current_dir` resolves symlinks, etc.
// We canonicalize BOTH paths because canonicalize returns paths UNC form on windows,
// but `std::env::current_dir` does not...
assert_eq!(canonical_cwd, canonical_tmpdir);
} else {
tmpdir.path().to_owned()
// Some platforms (wasi) don't support this, so we just compare the paths directly.
assert_eq!(cwd, tmpdir.path());
};

#[allow(deprecated)]
Expand Down
Loading