Skip to content

fix: correct arcade disasters ratios #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ugcodrr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correct arcade disasters ratios #843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62077c7
fix: correct arcade disasters ratios
ugcodrr May 12, 2026
da86aaf
Apply suggestion from @ugcodrr
ugcodrr May 12, 2026
312963d
fix(disasters): correct order of losses and wlr calculations in const…
ugcodrr May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/discord-bot/src/commands/ratios/ratios.command.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ export class RatiosCommand {

private getModeStats(game: PlayerStats[keyof PlayerStats], mode: GameModeWithSubModes<any>) {
if (mode.submodes.length !== 0) {
let stats = game[mode.api as keyof typeof game];
stats = stats[mode.submodes[0].api as keyof typeof game];
return mode.submodes[0].api === "overall" ? stats || game : stats;
const stats = game[mode.api as keyof typeof game];
const submodeStats = stats[mode.submodes[0].api as keyof typeof stats];
return mode.submodes[0].api === "overall" ? submodeStats || stats : submodeStats;
}

const stats = game[mode.api as keyof typeof game];
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/player/gamemodes/arcade/mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,11 @@ export class Disasters {
public constructor(data: APIData = {}, ap: APIData = {}) {
this.gamesPlayed = data.games_played;
this.wins = data.wins;
this.losses = data.losses;
this.wlr = ratio(this.wins, this.losses);
this.playtime = (data.time_survived ?? 0) * 1000;
this.survivals = new DisasterSurvivals(data.survived ?? {});
this.deaths = new DisastersDeaths(data.deaths ?? {});
this.losses = data.losses ?? this.deaths.overall;
Comment thread
ugcodrr marked this conversation as resolved.
Outdated
this.wlr = ratio(this.wins, this.losses);
this.powerups = ap.arcade_disasters_prepared;
}
}
Expand Down
Loading