Removes the statistical crate from dependencies.#203
Open
wesc wants to merge 1 commit intoStarlightSearch:mainfrom
Open
Removes the statistical crate from dependencies.#203wesc wants to merge 1 commit intoStarlightSearch:mainfrom
wesc wants to merge 1 commit intoStarlightSearch:mainfrom
Conversation
6011d14 to
4423cbc
Compare
4423cbc to
9d95154
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StatisticalChunker implementation requires the statistical package for computing mean, median, and stddev. This PR implements those functions and removes the statistical crate. There are a few reasons to do this:
test_statistical_chunker passes with the new implementations. Note that the old statistical implementations assert when input data doesn't hit a minimum length, and these new versions maintain the same behavior.
Here are the crates that are removed due to cutting out statistical:
I generated this PR with the help of Claude Code, and I have reviewed every line of it.