Skip to content

Redirect page slugs with spaces to underscore form #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jage wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Redirect page slugs with spaces to underscore form #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/controllers/page_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ def restrict_concealed(page)
end

get '/:slug' do
if params[:slug].include?(" ")
redirect "/#{params[:slug].tr(' ', '_')}", 301
end
@page = Page
.select(:id, :slug, :title, :concealed, :revision, :updated_on, :compiled_content, :author_id)
.eager_graph(:author)
Expand Down
7 changes: 7 additions & 0 deletions test/integration/app_not_logged_in_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ def test_nonexistent_page
assert_equal "/new/#{random_slug}", URI(redirect_location).path
end

def test_page_with_space_in_slug_redirects_to_underscore
get "/foo%20bar"

assert_equal 301, last_response.status
assert_equal "/foo_bar", URI(last_response["Location"]).path
end

def test_new
get "/new"

Expand Down
Loading