add Metro Olografix L'Aquila, change spaceapi endpoint for MX pescara#333
Merged
Conversation
s3lph
requested changes
May 28, 2026
s3lph
left a comment
s3lph
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for the update.
Your endpoints look fine, however you seem to have dropped a newline from the end of the directory.json file. Please re-add that newline, and then we're good to go.
michelangelomo
force-pushed
the
add-mx-aq
branch
2 times, most recently
from
95eaa0d to
34e2de3
Compare
Contributor
Author
|
@s3lph ops, my bad! fixed :) |
s3lph
requested changes
May 30, 2026
s3lph
left a comment
s3lph
left a comment
Member
There was a problem hiding this comment.
Thanks! One more thing: Your two new entries are in the wrong order. We're enforcing a lexical sorting of keys in the directory.json.
Sorry, missed it the first time around.
Comment on lines
+144
to
+145
| "Metro Olografix Pescara": "https://sede.olografix.org/s/pescara/spaceapi.json", | ||
| "Metro Olografix L'Aquila": "https://sede.olografix.org/s/laquila/spaceapi.json", |
Member
There was a problem hiding this comment.
Those should be the other way around for the canonical sorting order.
Contributor
Author
There was a problem hiding this comment.
Thank you for the heads up, fixed :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're adding a new endpoint make sure that