Konrad Guzek – Etap 4, React Basics#93
Closed
kguzek wants to merge 1 commit into
Closed
Conversation
jmorawiec
reviewed
Jun 30, 2025
| render(<SolvroProjectsCombobox />); | ||
| const combobox = screen.getByRole("combobox"); | ||
| expect(combobox).toBeInTheDocument(); | ||
| expect(combobox).toHaveTextContent(/^wyszukaj projekt/i); |
Member
There was a problem hiding this comment.
Jednyna rzecz, której ewentualnie bym się przyczepił, to wymienienie tego na po prostu "szukaj", żeby testy spasowały nawet w razie zmiany tekstu przycisku na coś bardziej zwięzłego. Tak poza tym nie mam żadnych uwag.
jmorawiec
reviewed
Jun 30, 2025
|
|
||
| async function clickCombobox() { | ||
| const user = userEvent.setup(); | ||
| render(<SolvroProjectsCombobox />); |
Member
There was a problem hiding this comment.
Zastanawiam się, czy w myśl idei izolacji testów nie powinniśmy wykonywać "render" w każdym komponencie z osobna
Member
Author
There was a problem hiding this comment.
wydaje mi się, że skoro jest to test jednostkowy dla jednego konkretnego komponentu to można założyć, że każdy test w tym pliku będzie go renderował i to tak samo, więc chyba nic nie szkodzi wrzucić to do jednej funkcji
jmorawiec
approved these changes
Jun 30, 2025
kguzek
force-pushed
the
konrad-guzek/4-react-basics
branch
from
2644dbe to
1aad2eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.